#58561 closed enhancement (fixed)
Backport: Block theme previews
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch gutenberg-merge |
Focuses: | Cc: |
Description
This PR backports the changes made to the block theme previews. I grouped them together instead of having one PR for each change because they would all depend on each other, which made more sense.
Backports:
https://github.com/WordPress/gutenberg/pull/50030
https://github.com/WordPress/gutenberg/pull/50335
https://github.com/WordPress/gutenberg/pull/50338
https://github.com/WordPress/gutenberg/pull/50354
https://github.com/WordPress/gutenberg/pull/51221
https://github.com/WordPress/gutenberg/pull/51312
https://github.com/WordPress/gutenberg/pull/50983
https://github.com/WordPress/wordpress-develop/pull/4376
Change History (14)
This ticket was mentioned in PR #4627 on WordPress/wordpress-develop by @onemaggie.
21 months ago
#1
- Keywords has-patch added
@onemaggie commented on PR #4627:
21 months ago
#3
@felixarntz @audrasjb would you please have another look?
@peterwilsoncc commented on PR #4627:
21 months ago
#4
During testing, I'm seeing an error when the active theme is a classic theme
- Activate the theme Twenty Twenty-One (classic theme)
- Click live preview on a block theme: twenty twenty-two
- An error message is displayed: The theme you are currently using is not compatible with the Site Editor.
The reverse case is unaffected: it's still possible to preview a classic theme while a block theme is active.
@isabel_brison commented on PR #4627:
21 months ago
#5
During testing, I'm seeing an error when the active theme is a classic theme
I suspect this is due to the npm packages not being updated yet in core. Can you confirm @MaggieCabrera ?
@onemaggie commented on PR #4627:
21 months ago
#6
During testing, I'm seeing an error when the active theme is a classic theme
I suspect this is due to the npm packages not being updated yet in core. Can you confirm @MaggieCabrera ?
This is in fact not happening when testing that flow using Gutenberg trunk and core 6.2.2. I can't say of the top of my head what's causing it, I'm going to double-check, but most likely we are just missing the npm packages like you said.
@scruffian commented on PR #4627:
21 months ago
#7
During testing, I'm seeing an error when the active theme is a classic theme
I suspect this is due to the npm packages not being updated yet in core. Can you confirm @MaggieCabrera ?
This is not the reason why it was failing - we found the cause was an incorrect GET param on the button. Having said that we are still finding that the feature isn't working correctly on this branch because the npm packages aren't updated yet. I think we'll need to wait for this to be done before we can confirm that this is working as expected.
@peterwilsoncc commented on PR #4627:
21 months ago
#8
Thanks for the pointer, I tried running npm run sync-gutenberg-packages
on this branch to see if I could test but without success. I'm going to leave it alone for the rest of the weekend and see if I have more success on Monday.
Trac ticket: [](https://core.trac.wordpress.org/ticket/58561)
This PR backports the changes made to the block theme previews. I grouped them together instead of having one PR for each change because they would all depend on each other, which made more sense.
Backports: