#58581 closed defect (bug) (fixed)
Twenty Twenty-Three: Remove perPage attribute where query inherits from global query
Reported by: | mikachan | Owned by: | azaozz |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
We should remove the perPage
attribute from the query loop blocks that inherit from the global query in Twenty Twenty-Three. If the block is inheriting the global query, then this should apply to the number of posts per page as well, making this attribute redundant.
Follow-on from this Gutenberg PR: https://github.com/WordPress/gutenberg/pull/51641
Change History (13)
This ticket was mentioned in PR #4649 on WordPress/wordpress-develop by @mikachan.
19 months ago
#1
- Keywords has-patch added
#4
@
19 months ago
- Keywords needs-testing removed
@audrasjb, this is not an urgent change but it's a small fix that has already been approved over on GitHub. Would it be possible to include this in 6.3? Thanks!
This ticket was mentioned in Slack in #core by mikachan. View the logs.
18 months ago
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
18 months ago
#9
@
18 months ago
- Owner set to audrasjb
- Status changed from new to accepted
Self assigning for commit
.
#10
@
18 months ago
- Owner changed from audrasjb to azaozz
- Status changed from accepted to assigned
And giving it to @azaozz as is proposed to commit it during the scrub :)
#12
@
18 months ago
Thank you for handling this! Does the GitHub PR need closing too?
@mikachan commented on PR #4649:
18 months ago
#13
Committed in https://core.trac.wordpress.org/changeset/56251. Thanks all!
Trac ticket: https://core.trac.wordpress.org/ticket/58581
We should remove the
perPage
attribute from the query loop blocks that inherit from the global query in Twenty Twenty-Three. If the block is inheriting the global query, then this should apply to the number of posts per page as well, making this attribute redundant.Follow-on from this Gutenberg PR: https://github.com/WordPress/gutenberg/pull/51641