WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58581 closed defect (bug) (fixed)

Twenty Twenty-Three: Remove perPage attribute where query inherits from global query

Reported by: mikachan's profile mikachan Owned by: azaozz's profile azaozz
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

We should remove the perPage attribute from the query loop blocks that inherit from the global query in Twenty Twenty-Three. If the block is inheriting the global query, then this should apply to the number of posts per page as well, making this attribute redundant.

Follow-on from this Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/51641

Change History (13)

This ticket was mentioned in ​PR #4649 on ​WordPress/wordpress-develop by ​@mikachan.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58581

We should remove the perPage attribute from the query loop blocks that inherit from the global query in Twenty Twenty-Three. If the block is inheriting the global query, then this should apply to the number of posts per page as well, making this attribute redundant.

Follow-on from this Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/51641

#2 @onemaggie
3 years ago

This looks good to me. Thank you for picking it up!

#3 @mikachan
3 years ago

  • Keywords needs-testing added

#4 @mikachan
3 years ago

  • Keywords needs-testing removed

@audrasjb, this is not an urgent change but it's a small fix that has already been approved over on GitHub. Would it be possible to include this in 6.3? Thanks!

This ticket was mentioned in ​Slack in #core by mikachan. ​View the logs.
3 years ago

#6 @davidbaumwald
3 years ago

  • Type changed from enhancement to defect (bug)

#7 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 6.3

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#9 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Self assigning for commit.

#10 @audrasjb
3 years ago

  • Owner changed from audrasjb to azaozz
  • Status changed from accepted to assigned

And giving it to @azaozz as is proposed to commit it during the scrub :)

#11 @azaozz
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 56251:

Twenty Twenty-Three: Remove the perPage attribute where the query inherits from the global query. The global attribute should be used instead.

Props: mikachan, onemaggie.
Fixes: #58581.

#12 @mikachan
3 years ago

Thank you for handling this! Does the ​GitHub PR need closing too?

Note: See TracTickets for help on using tickets.