Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#58613 closed defect (bug) (fixed)

Improve accessibility of install forms

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.3 Priority: normal
Severity: normal Version: 2.5
Component: Upgrade/Install Keywords: has-patch commit
Focuses: accessibility Cc:

Description

Many of the .form-table forms were significantly improved in r45835, but it looks like the installation form was missed.

Need to add aria-describedby to field description text.

The descriptive text has existed nearly since the installation was written; but at that time, aria-describedby didn't exist yet. So it's a bit ambiguous to say what version this issue appeared in. :shrug: We'll call it 2.5.

Attachments (1)

58613.diff (5.2 KB) - added by joedolson 12 months ago.
Add aria-describedby

Download all attachments as: .zip

Change History (10)

#1 @joedolson
12 months ago

  • Owner set to joedolson
  • Status changed from new to accepted

@joedolson
12 months ago

Add aria-describedby

#2 @joedolson
12 months ago

  • Keywords needs-copy-review has-patch added

The only awkward thing in here is having the privacy description attached to both radio buttons. A text update could make this clearer. Right now, we get

"Allow search engines to index this site; Note: Neither of these options blocks access to your site — it is up to search engines to honor your request."

"Discourage search engines from indexing this site; Note: Neither of these options blocks access to your site — it is up to search engines to honor your request."

I think it would be better if the note said simply "These options do not block access to your site — it is up to search engines to honor your request."

#3 @costdev
12 months ago

It seems that the specific text in the "Note:" string is only relevant to the "discourage" choice, as a user shouldn't have any concern/misunderstanding that "allow" would block access.

So something like this might be "ideal".

Allow:

Allow search engines to index this site

Discourage:

Discourage search engines from indexing this site; Note: Discouraging search engines does not block access to your site — it is up to search engines to honor your request.


However, for a message that could work for both choices:

Allow search engines to index this site; Note: This does not affect access to your site — it is up to search engines to honor your request.

Discourage search engines from indexing this site; Note: This does not affect access to your site — it is up to search engines to honor your request.

Where "This" could be changed to "Your choice" if "This" isn't clear enough in all locations of the string.

What do you think of the above @joedolson?

#4 @joedolson
12 months ago

It seems to me like the description provided - as you say - only provides clarification if a user is picking the discourage option. As such, we really only need additional text to describe that case, and it only needs to be attached to the discourage option.

So I think we could use the Discourage text, and remove the association for allow, since it should be clear that allow doesn't block any access.

This also reduces duplication of text and unnecessary verbosity.

#5 @costdev
12 months ago

Sounds good!

#7 @joedolson
12 months ago

  • Keywords commit added; needs-copy-review removed

#8 @joedolson
12 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56024:

Upgrade/Install: Add aria-describedby for input descriptions.

Accessibly associate field description text with relevant input fields. Add aria-describedby and target IDs for each description field. Update privacy text note to better reflect relevancy to specific fields.

Props costdev, joedolson.
Fixes #58613.

@joedolson commented on PR #4691:


12 months ago
#9

Fixed in r56024

Note: See TracTickets for help on using tickets.