Block editor layout issue

[bhrugesh12]

In WP RC1
When i try to edit any post and page, then trying to add block via add icon in editor. It seems to be so far as per previous version compare.

[bhrugesh12]

Replying to bhrugesh12:

In WP 6.3 RC1
When i try to edit any post and page, then trying to add block via add icon in editor. It seems to be so far as per previous version compare.

[huzaifaalmesbah]

I also face this same issue.

Environment
OS: Macos 13.4.1
Web Server: nginx/1.25.0
PHP: 8.1.21
WordPress: 6.4-alpha-56267
Browser: Chrome 115.0.5790.98
Theme: Twenty Twenty-One
Active Plugins: No plugins activated.

[huzaifaalmesbah]

I again check with WordPress 6.3-RC1-56265. I also face this same issue.

Environment
OS: Macos 13.4.1
Web Server: nginx/1.25.0
PHP: 8.1.21
WordPress: 6.3-RC1-56265
Browser: Chrome 115.0.5790.98
Theme: Twenty Twenty-One
Active Plugins: No plugins activated.

[audrasjb]

Fullscreen mode - can't reproduce

[audrasjb]

Not Fullscreen mode - can't reproduce either

[audrasjb]

I can't reproduce the issue using TT3 theme.
(Chrome / Mac OS / 13")

Let's still milestone this to 6.3.

[isabel_brison]

This issue was thought to be fixed in ​https://github.com/WordPress/gutenberg/pull/52356 which was included in 6.3 Beta 4.

I can reproduce it on 6.3 RC1, as well as on the 6.3 release branch, though I can't on trunk. Not 100% sure what's happening here, will continue investigating.

[bhrugesh12]

Replying to audrasjb:

I can't reproduce the issue using TT3 theme.
(Chrome / Mac OS / 13")

Let's still milestone this to 6.3.

Please check attached video for better understanding.

To avoid breaking updates.

Trac ticket: https://core.trac.wordpress.org/ticket/58847

Essentially copies the fix from the previous time we had this problem: ​https://github.com/WordPress/wordpress-develop/pull/4155#discussion_r1121383013

Hope we can make our popovers work with the latest versions of those packages before too much longer 😅 but given it's RC time again this seems like the safest option for now.

Thank you very much for this solution. @tellthemachines

[mukesh27]

Thanks @isabel_brison for the PR, Is it part of GB backport or we merge it right away?

[azaozz]

I can reproduce it on 6.3 RC1, as well as on the 6.3 release branch, though I can't on trunk.

Mmmm, weird. Could it be some sort of "caching gremlins" (may even be npm caching the packages)? :)

Cannot reproduce it. Tested both trunk and the 6.3 branch, in Firefox and Chromium, specifically tested in /build (same as production) with SCRIPT_DEBUG disabled.

The patch seems simple enough, and safe enough so thinking it can be committed to trunk if that will facilitate testing (the latest nightly build is here: ​https://wordpress.org/nightly-builds/wordpress-latest.zip). Then anybody that is experiencing this can test trunk and see if it fixes it, and if yes we can backport it to the 6.3 branch.

[isabel_brison]

In 56284:

Editor: fix popover positioning.

Pins the floating-ui package versions to avoid breaking changes when they update.

Props ramonopoly, spacedmonkey, bhrugesh12, huzaifaalmesbah, audrasjb, azaozz.
See #58847.

[isabel_brison]

Thanks @azaozz! I've committed the patch to trunk.

I was able to reproduce the issue eventually on trunk by deleting the node_modules and reinstalling. For folks testing the fix, try doing this on both trunk and the 6.3 branch and check the popover positioning each time.

Committed to trunk in r56284. Pending testing on trunk to check the issue is fixed, we can then commit it to the release branch.

[audrasjb]

Adding fixed-major workflow keyword.

Self assigning for review and potential backport to branch 6.3.

[audrasjb]

In 56289:

Editor: fix popover positioning.

Pins the floating-ui package versions to avoid breaking changes when they update.

Props isabel_brison, ramonopoly, spacedmonkey, bhrugesh12, huzaifaalmesbah, audrasjb, azaozz.
Reviewed by audrasjb.
Merges [56284] to the 6.3 branch.
Fixes #58847.

committed in https://core.trac.wordpress.org/changeset/56289