Update @nodelib/fs.scandir and @nodelib/fs.walkto the latest version (3.0.0, and 2.0.0)

[rajinsharwar]

Version 3.0.0 of fs.scandir library is available See ReadMe: ​https://www.npmjs.com/package/@nodelib/fs.scandir/v/3.0.0

Update @nodelib/fs.scandir and @nodelib/fs.walkto the latest version (3.0.0, and 2.0.0)

Trac ticket: https://core.trac.wordpress.org/ticket/58936

[rajinsharwar]

Updating the @nodelib/fs.walk and @nodelib/fs.scandir to the latest version

[desrosj]

Thanks for this one, @rajinsharwar!

Looking at this further, I am of the opinion that we should not be updating this independent of @wordpress/scripts, which is the only dependency listing these packages. The only exception is when performing npm audit fix to correct dependencies with known vulnerabilities.

For example, when running npm list @nodelib/fs.walk@1.2.8, the following tree is output:

└─┬ @wordpress/scripts@26.6.3
  ├─┬ eslint@8.45.0
  │ └── @nodelib/fs.walk@1.2.8
  └─┬ fast-glob@3.3.0
    └── @nodelib/fs.walk@1.2.8

While the update may be within the version constraints, if every possible available update was applied, it would create a fair amount of noise. Updating them within the package directly including these packages as dependencies will also result in better testing.

Going to close this out, but if another committer feels strongly otherwise it can be reopened and reconsidered.