Make WordPress Core

Opened 5 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#59118 closed enhancement (fixed)

Remove support for the mysql extension

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.3
Component: Database Keywords: has-patch has-unit-tests needs-testing
Focuses: Cc:

Description

The mysql extension is no longer used in PHP 7 or above. There's a good amount of conditional code in wpdb that can be removed now that only the mysqli functions are used.

It's unlikely there will be a noticeable performance gain from the removal of the dead conditional code, but every little helps, and maintenance will be simplified.

Change History (7)

This ticket was mentioned in PR #5017 on WordPress/wordpress-develop by @johnbillion.


5 weeks ago
#1

  • Keywords has-patch has-unit-tests added

Trac ticket:

This ticket was mentioned in PR #5017 on WordPress/wordpress-develop by @johnbillion.


5 weeks ago
#2

Trac ticket:

@mukesh27 commented on PR #5017:


5 weeks ago
#3

@johnbillion The PR have list of PHPCS issues that need to fix.

#4 @Hareesh Pillai
5 weeks ago

  • Keywords needs-testing added

Adding the needs-testing keyword.

On having a cursory glance, the changes look ok. This PR requires in-depth testing.

@johnbillion commented on PR #5017:


5 weeks ago
#5

@mukeshpanchal27 Yeah they _should_ all be about indentation as mentioned in the PR description. I didn't fix the indentation in order to keep the diff clean and it can be addressed in the commit.

#6 @johnbillion
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 56475:

Database: Remove support for the mysql extension.

The mysql extension is no longer used in PHP 7 or above. There's a good amount of conditional code in wpdb and the health checks that can be removed now that only the mysqli functions are used.

Fixes #59118

Note: See TracTickets for help on using tickets.