Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#59130 new defect (bug)

Twenty Seventeen: In "Latest Comments Block" space between comments increases on increasing the Typography Size

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch has-testing-info
Focuses: css Cc:

Description

In Twenty Seventeen Theme, The space between comments increases as we increase the Size from the typography Section. In other Themes, it is working perfectly.
Here is the Video of the issue : https://drive.google.com/file/d/1kRfza7b7ZDZ6mbd-65ydoTC5rUUSzgoR/view?usp=sharing

Attachments (3)

Screenshot 2023-08-17 at 6.48.36 PM.png (166.1 KB) - added by pitamdey 9 months ago.
screenshot for better understanding
59130.patch (973 bytes) - added by pitamdey 9 months ago.
After applying this solution the issue is resolved
59130.2.patch (1.0 KB) - added by shailu25 9 months ago.
Updated Patch

Download all attachments as: .zip

Change History (7)

@pitamdey
9 months ago

screenshot for better understanding

@pitamdey
9 months ago

After applying this solution the issue is resolved

#1 @sabernhardt
9 months ago

  • Focuses css added

The bottom margin should remain, though 4rem might be more appropriate than 4em.

@shailu25
9 months ago

Updated Patch

#2 @shailu25
9 months ago

I have updated patch & changed margin-bottom: 4rem instead of 4em in Comment Section

#3 @bhrugesh12
9 months ago

  • Keywords has-patch added

#4 @harshgajipara
9 months ago

  • Keywords has-testing-info added

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59130/59130.2.patch

Environment

OS: Windows
PHP: 8.1.9
WordPress: 6.3
Browser: Chrome
Theme: Twenty Seventeen
Plugins: None activated

Actual Results:

✅ Before patch: Comments block taking more spaces https://prnt.sc/VdcXfZ3eE1hy
✅ After patch: Comments block taking less spaces https://prnt.sc/tT1NmIPWWFw6

Note: See TracTickets for help on using tickets.