Twenty Seventeen: In "Latest Comments Block" space between comments increases on increasing the Typography Size

[pitamdey]

In Twenty Seventeen Theme, The space between comments increases as we increase the Size from the typography Section. In other Themes, it is working perfectly.
Here is the Video of the issue : ​https://drive.google.com/file/d/1kRfza7b7ZDZ6mbd-65ydoTC5rUUSzgoR/view?usp=sharing

[pitamdey]

screenshot for better understanding

[pitamdey]

After applying this solution the issue is resolved

[sabernhardt]

The bottom margin should remain, though 4rem might be more appropriate than 4em.

[shailu25]

Updated Patch

[shailu25]

I have updated patch & changed margin-bottom: 4rem instead of 4em in Comment Section

[harshgajipara]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59130/59130.2.patch

Environment

OS: Windows
PHP: 8.1.9
WordPress: 6.3
Browser: Chrome
Theme: Twenty Seventeen
Plugins: None activated

Actual Results:

✅ Before patch: Comments block taking more spaces ​https://prnt.sc/VdcXfZ3eE1hy
✅ After patch: Comments block taking less spaces ​https://prnt.sc/tT1NmIPWWFw6

[rajinsharwar]

Test Report

I have tested this patch: https://core.trac.wordpress.org/attachment/ticket/59130/59130.2.patch

Environment

OS: Windows
PHP: 8.1.23
WordPress: 6.6-alpha
Browser: Chrome
Theme: Twenty Seventeen

Actual Results:

✅ After patch: Comments block: ​https://prnt.sc/IU8t3uaYOevt

[sabernhardt]

For the record, this patch only affects the margin if the block is added within a post. In the widget context, the front-end bottom margin is still 1em (smaller, yet variable).

[karmatosed]

Assigning to myself to take through commit. Thank you everyone for the work done on this.

[karmatosed]

In 58367:

Twenty Seventeen: Fixes space between latest comments blocks as typography size is increased.

The latest comments block space between comments not increases based on typography size. This only impacts the margin if added within a post, widgets on the front-end still only have a 1em margin which is smaller yet variable.

Props pitamdey, sabernhardt, shailu25, harshgajipara, rajinsharwar.
Fixes #59130.