Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#59177 new defect (bug)

dbDelta doesn't handle changing the DEFAULT value of a column from NULL to ''

Reported by: bogdanhapcayardicom's profile bogdanhapcayardicom Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: dev-feedback
Focuses: Cc:

Description

Shouldn't this be a strict comparison https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/upgrade.php#L3064? Otherwise that condition will be false and the column will remain unchanged.

Attachments (1)

Screenshot 2023-08-23 at 18.31.17.png (960.8 KB) - added by bogdanhapcayardicom 9 months ago.
Showing the issue. See the WATCH pane.

Download all attachments as: .zip

Change History (4)

@bogdanhapcayardicom
9 months ago

Showing the issue. See the WATCH pane.

This ticket was mentioned in Slack in #core-upgrade-install by pbiron. View the logs.


9 months ago

This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.


9 months ago

#3 @ironprogrammer
9 months ago

  • Keywords dev-feedback added
  • Version 6.3 deleted

Welcome to Trac, @bogdanhapcayardicom, and thank you for this report!

I've added dev-feedback to help flag this for broader Core dev awareness.

Note: See TracTickets for help on using tickets.