WordPress.org
Get WordPress

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 6 weeks ago

#59296 closed enhancement (fixed)

Sync minor code quality tweaks to WP_REST_Global_Styles_Controller

Reported by: ramonopoly's profile ramonopoly Owned by: isabel_brison's profile isabel_brison
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: REST API Keywords: has-patch gutenberg-merge
Focuses: Cc:

Description

For 6.4, sync a couple of minor code quality tweaks to the WP_REST_Global_Styles_Controller class.

  1. Remove unnecessary local variable in ::get_theme_items()
  2. Change ::validate_custom_css() access modifier from private to protected so that the method is inherited if the class is extended

Gutenberg PRs:

​https://github.com/WordPress/gutenberg/pull/53618
​https://github.com/WordPress/gutenberg/pull/52819

Change History (5)

This ticket was mentioned in ​PR #5152 on ​WordPress/wordpress-develop by ​@ramonopoly.
3 months ago #1

For 6.4, sync a couple of minor code quality tweaks to the WP_REST_Global_Styles_Controller class.

  1. Remove unnecessary local variable in ::get_theme_items()
  2. Change ::validate_custom_css() access modifier from private to protected so that the method is inherited if the class is extended

Gutenberg PRs:

Trac ticket: https://core.trac.wordpress.org/ticket/59296

#2 @isabel_brison
3 months ago

  • Component changed from Editor to REST API

#3 @isabel_brison
3 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56575:

REST API: quality tweaks to WP_REST_Global_Styles_Controller.

Removes redundant local variable and changes validate_custom_css() access modifier from private to protected.

Props ramonopoly, spacedmonkey.
Fixes #59296.

​@isabel_brison commented on ​PR #5152:
3 months ago #4

Committed in r56575.

This ticket was mentioned in ​Slack in #core-upgrade-install by jorbin. ​View the logs.
6 weeks ago

Note: See TracTickets for help on using tickets.