#59296 closed enhancement (fixed)
Sync minor code quality tweaks to WP_REST_Global_Styles_Controller
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.4 | Priority: | normal |
| Severity: | normal | Version: | 6.4 |
| Component: | REST API | Keywords: | has-patch gutenberg-merge |
| Focuses: | Cc: |
Description
For 6.4, sync a couple of minor code quality tweaks to the WP_REST_Global_Styles_Controller class.
- Remove unnecessary local variable in ::get_theme_items()
- Change ::validate_custom_css() access modifier from private to protected so that the method is inherited if the class is extended
Gutenberg PRs:
https://github.com/WordPress/gutenberg/pull/53618
https://github.com/WordPress/gutenberg/pull/52819
Change History (5)
This ticket was mentioned in PR #5152 on WordPress/wordpress-develop by @ramonopoly.
20 months ago
#1
#3
@
20 months ago
- Owner set to isabel_brison
- Resolution set to fixed
- Status changed from new to closed
In 56575:
@isabel_brison commented on PR #5152:
20 months ago
#4
Committed in r56575.
This ticket was mentioned in Slack in #core-upgrade-install by jorbin. View the logs.
18 months ago
Note: See
TracTickets for help on using
tickets.
For 6.4, sync a couple of minor code quality tweaks to the WP_REST_Global_Styles_Controller class.
::get_theme_items()::validate_custom_css()access modifier from private to protected so that the method is inherited if the class is extendedGutenberg PRs:
Trac ticket: https://core.trac.wordpress.org/ticket/59296