#59349 closed defect (bug) (duplicate)
Remove the Unused global variables in the wp-includes folder.
Reported by: | upadalavipul | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | General | Keywords: | |
Focuses: | coding-standards | Cc: |
Description
I have reviewed the code and found Unused global variables in one of the below files. Please check the below file:
File:
- wp-includes/template.php
Attachments (1)
Change History (3)
#1
@
12 months ago
- Keywords close added
Thanks for opening this ticket! However, I believe that these globals are included on purpose, as the function docblock says:
The globals are set up for the template file to ensure that the WordPress environment is available from within the function. The query variables are also available.
So, the globals are then available to the require(_once)
d files.
#2
@
12 months ago
- Keywords close removed
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
Hi there, thanks for the patch!
As noted in comment:1 and previously in comment:5:ticket:59185, these globals should not be removed.
Closing as a duplicate of #59185.
Note: See
TracTickets for help on using
tickets.
Added patch