Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#59371 closed defect (bug) (fixed)

Adjust theme details buttons to improve proximity of controls

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.4 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

Related: #40822

https://cldup.com/bzuc02OcHD.jpg

The theme modal at Appearance > Themes places the 'Delete' button remotely from other theme buttons. For improved accessibility, the three buttons should be grouped together.

Should also switch order of buttons so the Primary action is first: Live Preview / Activate / Delete.

Attachments (2)

59371.jpg (210.3 KB) - added by joedolson 7 months ago.
Screenshot with patch
59371.diff (2.8 KB) - added by joedolson 7 months ago.
Update order of buttons & center.

Download all attachments as: .zip

Change History (7)

@joedolson
7 months ago

Screenshot with patch

@joedolson
7 months ago

Update order of buttons & center.

#1 @joedolson
7 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

While looking into this, I also observed that the color of the delete link failed color contrast at 4.4:1, so this patch also adjusts the color to the next darker red shade.

To test: verify that buttons are in the new order and orientation.

#2 @joedolson
7 months ago

  • Keywords needs-testing removed

Logistically, this will be more sensible to commit simultaneously with #59372; test this using the patch on that ticket.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


7 months ago

#4 @joedolson
7 months ago

In 56639:

Administration: Improve control proximity in theme details modal.

Make the theme details modals in the Customizer and at Appearance > Themes consistent. Change the order of controls so both modals are in the same sequence, center all controls in both desktop and mobile views, and change delete link color to meet color contrast requirements.

Props trishasalas, afercia, melchoyce, karmatosed, cathibosco1, michaelarestad, joedolson, petitphp, mikinc860.
Fixes #59372. See #59371, #40822.

#5 @joedolson
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.