Make WordPress Core

Opened 5 months ago

Last modified 2 weeks ago

#59493 reopened defect (bug)

Blank CSS line removed from code

Reported by: ravipatel's profile ravipatel Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

Removed a blank CSS which is not needed in the code.

Attachments (4)

59493-1.patch (3.7 KB) - added by ravipatel 5 months ago.
Added more themes file css where have blank css lines.
59493.patch (1.8 KB) - added by viralsampat 5 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
59493.2.patch (963 bytes) - added by viralsampat 5 months ago.
I have checked above mentioned issue and I have added its patch.
59493.3.patch (501 bytes) - added by viralsampat 8 weeks ago.
I have checked above mentioned issue and founds one more file. Here, I have added my patch.

Download all attachments as: .zip

Change History (17)

This ticket was mentioned in PR #5348 on WordPress/wordpress-develop by ravikumarup.


5 months ago
#1

  • Keywords has-patch added

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [](https://core.trac.wordpress.org/ticket/59493#ticket)

#2 @ravipatel
5 months ago

  • Component changed from Administration to Themes
  • Keywords has-patch removed

#3 @ravipatel
5 months ago

  • Keywords has-patch added

ravikumarup commented on PR #5348:


5 months ago
#4

Created pull request by another email.

This ticket was mentioned in PR #5349 on WordPress/wordpress-develop by @ravipatel.


5 months ago
#5

Blank CSS line removed from code which is not needed.

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [] (https://core.trac.wordpress.org/ticket/59493)

@ravipatel
5 months ago

Added more themes file css where have blank css lines.

#6 @sabernhardt
5 months ago

  • Component changed from Themes to Bundled Theme

@viralsampat
5 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

#7 @ravipatel
5 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Added a pull request for a code solution.
https://github.com/WordPress/wordpress-develop/pull/5349

Also added a patch related this, please review in it.

#8 @ravipatel
5 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#9 @ravipatel
5 months ago

  • Focuses coding-standards added

This ticket was mentioned in PR #5477 on WordPress/wordpress-develop by @sabernhardt.


5 months ago
#10

  • Removes empty CSS rulesets in Twenty Ten, Twenty Eleven, Twenty Twelve and Twenty Fourteen.
  • Removes empty lines within rulesets in Twenty Seventeen and Twenty Twenty-One.
  • Rearranges some comments in the SCSS files for Twenty Nineteen so they do not create rulesets without properties.
  • Switches some of Twenty Twenty-One's comments from multi-line /* */ format to single-line // format, and those do not appear in the compiled stylesheet.

Props: ravipatel, viralsampat

Trac 59493

#11 @sabernhardt
5 months ago

  • Milestone changed from Awaiting Review to 6.5

I recommend revisiting other comments in Twenty Nineteen's styles on a separate ticket. Several compiled comments appear inside an earlier ruleset, away from the styles they explain, but they do not relate to empty lines or rulesets.

@viralsampat
5 months ago

I have checked above mentioned issue and I have added its patch.

This ticket was mentioned in PR #5643 on WordPress/wordpress-develop by @ravipatel.


4 months ago
#12

CSS coding standard : Do not use empty ruleset

Trac ticket: https://core.trac.wordpress.org/ticket/59493

@viralsampat
8 weeks ago

I have checked above mentioned issue and founds one more file. Here, I have added my patch.

#13 @sabernhardt
2 weeks ago

  • Milestone changed from 6.5 to Future Release
Note: See TracTickets for help on using tickets.