Bundled themes: remove blank CSS lines

[ravipatel]

Removed a blank CSS which is not needed in the code.

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [](https://core.trac.wordpress.org/ticket/59493#ticket)

Created pull request by another email.

Blank CSS line removed from code which is not needed.

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [] (https://core.trac.wordpress.org/ticket/59493)

[ravipatel]

Added more themes file css where have blank css lines.

[viralsampat]

I have checked above mentioned issue and founds few more files. I have applied its patch.

[ravipatel]

Added a pull request for a code solution.
​https://github.com/WordPress/wordpress-develop/pull/5349

Also added a patch related this, please review in it.

• Removes empty CSS rulesets in Twenty Ten, Twenty Eleven, Twenty Twelve and Twenty Fourteen.
• Removes empty lines within rulesets in Twenty Seventeen and Twenty Twenty-One.
• Rearranges some comments in the SCSS files for Twenty Nineteen so they do not create rulesets without properties.
• Switches some of Twenty Twenty-One's comments from multi-line /* */ format to single-line // format, and those do not appear in the compiled stylesheet.

Props: ravipatel, viralsampat

Trac 59493

[sabernhardt]

I recommend revisiting other comments in Twenty Nineteen's styles on a separate ticket. Several compiled comments appear inside an earlier ruleset, away from the styles they explain, but they do not relate to empty lines or rulesets.

[viralsampat]

I have checked above mentioned issue and I have added its patch.

CSS coding standard : Do not use empty ruleset

Trac ticket: https://core.trac.wordpress.org/ticket/59493

[viralsampat]

I have checked above mentioned issue and founds one more file. Here, I have added my patch.

[ravipatel]

@sabernhardt this one covered in 6.5?

[sabernhardt]

I just refreshed the map files for Twenty Twenty-One with current trunk.

@sabernhardt can we remove this Blank CSS line also ?

/src/wp-content/themes/twentyten/functions.php Line no 285,286

#headimg #name { }
#headimg #desc { }

Ref: ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyten/functions.php#L285

@sabernhardt can we remove this Blank CSS line also ?

/src/wp-content/themes/twentyten/functions.php Line no 285,286

#headimg #name { }
#headimg #desc { }

Ref: ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyten/functions.php#L285

[shailu25]

Sorry its my Mistake, it's just inline comment , so no need to remove.

[poena]

I see that at least one PR changes code that is not a bundled theme, this makes me unsure of which PR should be tested, and if the description and component is correct?

[shailu25]

​PR 5477 is correct PR (All changes are included in this PR)

[sabernhardt]

This ticket was focused on bundled themes at the beginning, so I would like to keep it that way (updating PR 5477 as necessary).

Update: the wp-embed-template styles have a separate ticket: #61085.

https://core.trac.wordpress.org/changeset/58063

[karmatosed]

Just to confirm the current situation here:

• PR #5643 fixed the wp-embed-template styles.
• There is an outstanding PR 5477 with all the fixes for this ticket: ​https://github.com/WordPress/wordpress-develop/pull/5477

[snehapatil02]

I have tested ​https://github.com/WordPress/wordpress-develop/pull/5477 PR on the following themes: Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Fourteen, Twenty Seventeen, Twenty Nineteen, and Twenty Twenty-One.

• All changes were applied correctly without any visual or functional issues on the site.
• The themes were rendered as expected, and no new issues were introduced.

[karmatosed]

Thank you everyone. I am going to move this through to commit now.

[karmatosed]

In 58290:

Bundled Themes: Removes blank CSS lines.       

This removes blank CSS lines across multiple themes. Included are Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Fourteen, Twenty Seventeen, Twenty Nineteen and Twenty Twenty-One.

Props ravipatel, ravikumarup, sabernhardt, viralsampat, shailu25, poena, swisspidy, snehapatil02.
Fixes #59493.

[viralsampat]

I have added another patch.

[sabernhardt]

[58290] already made the changes in 59493.4.patch

[karmatosed]

We tend to use the commit keywords to track things so I am going to leave them on for now. This is closed though as has had a commit made. If other changes are needed we can review in a new issue.

Hi @ravikumarup!

When you have a chance, could you kindly share your w.org account? It's required to ensure you receive proper credit in the upcoming 6.6 release!

For future contributions, could you please follow the ​steps listed in the handbook to connect your WordPress.org and GitHub accounts? It helps automate the process of giving you attribution based on commit messages to WordPress Core.

Thank you!

Committed in r58290

[swissspidy]

#61977 was marked as a duplicate.