Make WordPress Core

Opened 9 months ago

Closed 3 weeks ago

Last modified 3 weeks ago

#59493 closed defect (bug) (fixed)

Bundled themes: remove blank CSS lines

Reported by: ravipatel's profile ravipatel Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

Removed a blank CSS which is not needed in the code.

Attachments (5)

59493-1.patch (3.7 KB) - added by ravipatel 9 months ago.
Added more themes file css where have blank css lines.
59493.patch (1.8 KB) - added by viralsampat 9 months ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
59493.2.patch (963 bytes) - added by viralsampat 8 months ago.
I have checked above mentioned issue and I have added its patch.
59493.3.patch (501 bytes) - added by viralsampat 6 months ago.
I have checked above mentioned issue and founds one more file. Here, I have added my patch.
59493.4.patch (1.6 KB) - added by viralsampat 3 weeks ago.
I have added another patch.

Download all attachments as: .zip

Change History (34)

This ticket was mentioned in PR #5348 on WordPress/wordpress-develop by ravikumarup.


9 months ago
#1

  • Keywords has-patch added

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [](https://core.trac.wordpress.org/ticket/59493#ticket)

#2 @ravipatel
9 months ago

  • Component changed from Administration to Themes
  • Keywords has-patch removed

#3 @ravipatel
9 months ago

  • Keywords has-patch added

ravikumarup commented on PR #5348:


9 months ago
#4

Created pull request by another email.

This ticket was mentioned in PR #5349 on WordPress/wordpress-develop by @ravipatel.


9 months ago
#5

Blank CSS line removed from code which is not needed.

Coding standard CSS, removed a blank line in CSS.

Removed a blank CSS which is not needed in the code.

Trac ticket: [] (https://core.trac.wordpress.org/ticket/59493)

@ravipatel
9 months ago

Added more themes file css where have blank css lines.

#6 @sabernhardt
9 months ago

  • Component changed from Themes to Bundled Theme

@viralsampat
9 months ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

#7 @ravipatel
9 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Added a pull request for a code solution.
https://github.com/WordPress/wordpress-develop/pull/5349

Also added a patch related this, please review in it.

#8 @ravipatel
9 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#9 @ravipatel
9 months ago

  • Focuses coding-standards added

This ticket was mentioned in PR #5477 on WordPress/wordpress-develop by @sabernhardt.


8 months ago
#10

  • Removes empty CSS rulesets in Twenty Ten, Twenty Eleven, Twenty Twelve and Twenty Fourteen.
  • Removes empty lines within rulesets in Twenty Seventeen and Twenty Twenty-One.
  • Rearranges some comments in the SCSS files for Twenty Nineteen so they do not create rulesets without properties.
  • Switches some of Twenty Twenty-One's comments from multi-line /* */ format to single-line // format, and those do not appear in the compiled stylesheet.

Props: ravipatel, viralsampat

Trac 59493

#11 @sabernhardt
8 months ago

  • Milestone changed from Awaiting Review to 6.5

I recommend revisiting other comments in Twenty Nineteen's styles on a separate ticket. Several compiled comments appear inside an earlier ruleset, away from the styles they explain, but they do not relate to empty lines or rulesets.

@viralsampat
8 months ago

I have checked above mentioned issue and I have added its patch.

This ticket was mentioned in PR #5643 on WordPress/wordpress-develop by @ravipatel.


8 months ago
#12

CSS coding standard : Do not use empty ruleset

Trac ticket: https://core.trac.wordpress.org/ticket/59493

@viralsampat
6 months ago

I have checked above mentioned issue and founds one more file. Here, I have added my patch.

#13 @sabernhardt
4 months ago

  • Milestone changed from 6.5 to Future Release

#14 @ravipatel
3 months ago

@sabernhardt this one covered in 6.5?

#15 @sabernhardt
3 months ago

  • Milestone changed from Future Release to 6.6
  • Owner set to sabernhardt
  • Status changed from reopened to accepted

I just refreshed the map files for Twenty Twenty-One with current trunk.

@shailu25 commented on PR #5477:


3 months ago
#16

@sabernhardt can we remove this Blank CSS line also ?

/src/wp-content/themes/twentyten/functions.php Line no 285,286

#headimg #name { }
#headimg #desc { }

Ref: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyten/functions.php#L285

@shailu25 commented on PR #5477:


3 months ago
#17

@sabernhardt can we remove this Blank CSS line also ?

/src/wp-content/themes/twentyten/functions.php Line no 285,286

#headimg #name { }
#headimg #desc { }

Ref: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyten/functions.php#L285

#18 @shailu25
3 months ago

Sorry its my Mistake, it's just inline comment , so no need to remove.

Last edited 3 months ago by shailu25 (previous) (diff)

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


2 months ago

#20 @poena
2 months ago

I see that at least one PR changes code that is not a bundled theme, this makes me unsure of which PR should be tested, and if the description and component is correct?

#21 @shailu25
2 months ago

PR 5477 is correct PR (All changes are included in this PR)

Last edited 2 months ago by shailu25 (previous) (diff)

#22 @sabernhardt
2 months ago

  • Keywords needs-testing added
  • Summary changed from Blank CSS line removed from code to Bundled themes: remove blank CSS lines

This ticket was focused on bundled themes at the beginning, so I would like to keep it that way (updating PR 5477 as necessary).

Update: the wp-embed-template styles have a separate ticket: #61085.

Last edited 2 months ago by sabernhardt (previous) (diff)

#24 @karmatosed
6 weeks ago

Just to confirm the current situation here:

#25 @snehapatil02
5 weeks ago

I have tested https://github.com/WordPress/wordpress-develop/pull/5477 PR on the following themes: Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Fourteen, Twenty Seventeen, Twenty Nineteen, and Twenty Twenty-One.

  • All changes were applied correctly without any visual or functional issues on the site.
  • The themes were rendered as expected, and no new issues were introduced.

#26 @sabernhardt
3 weeks ago

  • Keywords commit added; needs-testing removed

#27 @karmatosed
3 weeks ago

  • Owner changed from sabernhardt to karmatosed
  • Status changed from accepted to assigned

Thank you everyone. I am going to move this through to commit now.

#28 @karmatosed
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58290:

Bundled Themes: Removes blank CSS lines.       

This removes blank CSS lines across multiple themes. Included are Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Fourteen, Twenty Seventeen, Twenty Nineteen and Twenty Twenty-One.

Props ravipatel, ravikumarup, sabernhardt, viralsampat, shailu25, poena, swisspidy, snehapatil02.
Fixes #59493.

@viralsampat
3 weeks ago

I have added another patch.

#29 @sabernhardt
3 weeks ago

  • Keywords commit removed

[58290] already made the changes in 59493.4.patch

Note: See TracTickets for help on using tickets.