Make WordPress Core

Opened 9 months ago

Closed 7 months ago

Last modified 7 months ago

#59495 closed enhancement (fixed)

Twenty Twenty-One: add subject tags in stylesheet

Reported by: sumisubedi's profile sumisubedi Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: 2nd-opinion has-patch
Focuses: Cc:

Description

Theme can add up to 3 subject tags and it is missing.

Blog and Portfolio are suitable tag for this theme.

Change History (5)

This ticket was mentioned in PR #5350 on WordPress/wordpress-develop by sumisubedi.


9 months ago
#1

  • Keywords has-patch added

Subject tags are missing. Added two subject tags that suit for this theme, blog and portfolio.

https://core.trac.wordpress.org/ticket/59495

#2 @sabernhardt
9 months ago

  • Summary changed from Missing Subject tags in Twenty Twenty One theme to Twenty Twenty-One: add subject tags in stylesheet
  • Version changed from trunk to 5.6

Hi and thanks for the ticket!

Note: changes to the 'Tags' list will need to be made in /assets/sass/01-settings/file-header.scss and compiled to all versions of the stylesheet (style.css, style-rtl.css and ie.css).

Apparently the list has only had one revision since initial commit, to remove the 'flexible-header' tag.

Both blog and portfolio are mentioned in the readme.txt: "See how Twenty Twenty-One elevates your portfolio, business website, or personal blog."

Twenty Twenty-Two, Twenty Twenty-Three and Twenty Twenty-Four all include blog, portfolio and news.

#3 @SergeyBiryukov
7 months ago

  • Milestone changed from Awaiting Review to 6.5

#4 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57138:

Twenty Twenty-One: Add "blog" and "portfolio" subject tags.

Follow-up to [49216], [49574].

Props sumisubedi, sabernhardt.
Fixes #59495.

@SergeyBiryukov commented on PR #5350:


7 months ago
#5

Thanks for the PR! Merged in r57138.

Note: See TracTickets for help on using tickets.