Opened 11 months ago
Closed 4 months ago
#59688 closed enhancement (fixed)
Add descriptions to patterns in bundled themes
Reported by: | poena | Owned by: | karmatosed |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch needs-testing |
Focuses: | accessibility, docs | Cc: |
Description
Patterns have a parameter called "Description". The description is used in the WordPress interface, to add context for users that can not see or use the pattern preview. For example users of screen readers.
All patterns without the "Inserter" parameter set to "false" or "no", should use the description parameter (These patterns are hidden in the block inserter and do not use the descriptions).
Patterns in bundled themes that are missing descriptions needs to be updated.
Patterns can be registered using the patterns folder or with register_block_pattern() and both type of patterns should be updated.
Attachments (3)
Change History (18)
#1
@
10 months ago
- Keywords has-patch needs-testing added
I tested with VoiceOver, would be awesome if can be tested on other screen readers.
#2
@
10 months ago
For the twentytwentytwo theme, I noticed most of the title
of the pattern is already descriptive. Would a description
still be needed in this case?
#4
@
8 months ago
- Owner set to audrasjb
- Status changed from new to reviewing
Self assigning for review
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
8 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
7 months ago
#7
@
7 months ago
I checked your patch @StringPiggy, I think combine patch good for test and other tasks. can you update?
#8
@
7 months ago
I think combine patch good for test and other tasks. can you update?
Hi @huzaifaalmesbah, apologies for the confusing, as this is one of my first contributions here.
I might have done it in a misunderstanding way, the 59688.3.diff is a full diff (with changes for twentytwentyfour and twentytwentythree theme).
#9
@
7 months ago
@StringPiggy Sorry for the confusion. This is my mistake. Now I check your patch 59688.3 this for tt4 and tt3.
#10
@
7 months ago
- Milestone changed from 6.5 to 6.6
Punting as 6.5 beta 1 is today, so no more enhancements.
#11
@
5 months ago
@poena are you happy with the patch here as you were the original creator of this ticket and I want to be sure we are all aligned before moving into commit here. I also feel we might want to answer questions such as:
For the twentytwentytwo theme, I noticed most of the title of the pattern is already descriptive. Would a description still be needed in this case?
#12
@
5 months ago
No, if the title is descriptive then a second description is not needed.
The descriptions for the "page" patterns are long, but I don't think it can be helped, after all these patterns have a lot of content.
It would be good with a final review from a native English speaker. :)
Diff for twentytwentyfour theme