WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 16 months ago

#59887 closed defect (bug) (fixed)

The description of the `attributes` key for the parameter `$args` of the `wp_admin_notice` function is omitted.

Reported by: tmatsuur's profile tmatsuur Owned by: audrasjb's profile audrasjb
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.4
Component: Administration Keywords: good-first-bug has-patch commit
Focuses: docs Cc:

Description (last modified by sabernhardt)

The description of the parameter $args in the wp_get_admin_notice function has the contents of the attributes key, but the wp_admin_notice function does not.

 *     @type string[] $attributes         Optional. Additional attributes for the notice div. Default empty array.

The parameters of these two functions are common and should be unified.

Change History (7)

#1 @sabernhardt
2 years ago

  • Component changed from General to Administration
  • Description modified (diff)
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 6.5
  • Summary changed from The description of the `attribute` key for the parameter $args of the wp_admin_notice function is omitted. to The description of the `attributes` key for the parameter `$args` of the `wp_admin_notice` function is omitted.
  • Type changed from feature request to defect (bug)

#2 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

This ticket was mentioned in ​PR #5666 on ​WordPress/wordpress-develop by ​@ashrafulsarkar.
2 years ago #3

  • Keywords has-patch added; needs-patch removed

attributes key description added into wp_admin_notice function.

Trac ticket: #59887

#4 @sabernhardt
2 years ago

  • Keywords commit added

#5 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57279:

Docs: Improve wp_admin_notice() function docblock.

This changeset adds a description for the attributes key of $args in wp_admin_notice().

Props tmatsuur.
Fixes #59887.

#6 @sabernhardt
2 years ago

Added props manually for ashrafulsarkar.

​@SergeyBiryukov commented on ​PR #5666:
16 months ago #7

Thanks for the PR! Looks like this was merged in r57279.

Note: See TracTickets for help on using tickets.