PHPUnit test for wp_timezone_choice

[pbearne]

started the test but found and issue with setting the locale as the city files is missing the labels
asking on slack for help ​https://wordpress.slack.com/team/U02S95N2X

[swissspidy]

@pbearne Is this question about the missing translations still open?

Strings like "Select a city" are not in the continents-cities-es_ES.mo file but the regular es_ES.mo file.

Note that translation files within tests/phpunit/data/languages/ usually only contain a tiny amount of strings just for testing to keep things simpler.

[pbearne]

@swissspidy yes
I can add the needed strings but need make sure that is OK

[pbearne]

removed extra strings from the translation files

[pbearne]

Had to add the text strings to the new continents-cities-es_ES.l10n.php and ES.l10n.php files

add the string in the new fields to the.po and created .mo for them

[desrosj]

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

[audrasjb]

I added some small change requests in the PR ;)

[audrasjb]

Self assigning for final review and commit

[audrasjb]

Moving for 6.9 consideration

[rollybueno]

The PR's latest trunk merged was 6 months ago and the Docker does not initiate. Not until I merge latest trunk after fetching. Command used:

git fetch upstream pull/5694/head:pr-5694
git checkout pr-5694

[rollybueno]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/5694

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.29.0
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: Linux
• Theme: Twenty Twenty-One 2.6
• MU Plugins: None activated
• Plugins:
  • Query Monitor 3.18.0
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Additional Notes

• Merge latest trunk manually when fetching the PR

Supplemental Artifacts

Spanish translations on Timezone:

Unit tests:

[audrasjb]

Removing myself from some tickets as I won't be super available for 6.9.

[welcher]

Reviewed in the 6.9 bug scrub today. We're 1 week from RC 1 and this looks like it's ready.

[wildworks]

Hi @pbearne, do you have the bandwidth to address the feedback added to the pull request?

If there is no progress by the RC1 release next week, I will punt this ticket to 7.0.

[pbearne]

Replying to wildworks:

Hi @pbearne, do you have the bandwidth to address the feedback added to the pull request?

If there is no progress by the RC1 release next week, I will punt this ticket to 7.0.

Done

@pbearne did you see my PR?

[wildworks]

It appears that all feedback has been addressed.

did you see my PR?

@SirLouen Can you apply your suggestions directly to this PR? Or can you provide a link to the PR you're referring to?

[welcher]

This was reviewed in the 6.9 bug scrub today. As we're releasing RC 1 tomorrow, I'm going to punt this.

[westonruter]

Removing commit because there may be additional changes proposed by @SirLouen not yet applied.

@westonruter it was only some little tweaks I sent back in the day to @pbearne 's branch
​https://github.com/pbearne/wordpress-develop/pull/183

@SirLouen I fixed the merge conflicts and merged the branch into this one.

As far as I can see, yes, it looks ready for commit. But I don't have any experience with adding files to ‎tests/phpunit/data so I defer to someone with i18n expertise, especially @swissspidy.

[juanmaguitar]

From today's Bug Srub

It has a PR that looks ready to commit. We can just add the needs-testing keyword.

[audrasjb]

Removing needs-testing as this is a unit test ticket.

@swissspidy This PR seems ready to be merged. As per ​this comment do you think you'll be able to have a final look at it before WP 7.0 final release date (​in a few weeks)

🚢 it

@swissspidy The tests weren't passing after 9165507. It seems some dir=auto attributes were missing from the tests. I added them in bb85bc6. Please review.

Ah thanks. Still good to go :)

[SergeyBiryukov]

In 62156:

Tests: Add unit tests for wp_timezone_choice().

Follow-up to [57145], [59931].

Reviewed by westonruter, swissspidy, SergeyBiryukov.

Props pbearne, SirLouen, wildworks, westonruter, swissspidy, audrasjb, juanmaguitar, rollybueno, welcher, SergeyBiryukov.
Fixes #59941.