WordPress.org
Get WordPress

Make WordPress Core

Opened 16 months ago

Last modified 7 days ago

#59941 reviewing defect (bug)

PHPUnit test for wp_timezone_choice

Reported by: pbearne's profile pbearne Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Date/Time Keywords: has-patch has-unit-tests
Focuses: tests Cc:

Description


Change History (14)

This ticket was mentioned in ​PR #5694 on ​WordPress/wordpress-develop by ​@pbearne.
16 months ago #1

  • Keywords has-patch has-unit-tests added

This ticket was mentioned in ​Slack in #polyglots by pbearne. ​View the logs.
16 months ago

#3 @pbearne
16 months ago

started the test but found and issue with setting the locale as the city files is missing the labels
asking on slack for help ​https://wordpress.slack.com/team/U02S95N2X

#4 @swissspidy
13 months ago

@pbearne Is this question about the missing translations still open?

Strings like "Select a city" are not in the continents-cities-es_ES.mo file but the regular es_ES.mo file.

Note that translation files within tests/phpunit/data/languages/ usually only contain a tiny amount of strings just for testing to keep things simpler.

#5 @pbearne
13 months ago

@swissspidy yes
I can add the needed strings but need make sure that is OK

#6 @SergeyBiryukov
13 months ago

  • Summary changed from PPHunit test for wp_timezone_choice to PHPUnit test for wp_timezone_choice

#7 @pbearne
13 months ago

  • Owner set to pbearne
  • Status changed from new to assigned

removed extra strings from the translation files

#8 @pbearne
13 months ago

Had to add the text strings to the new continents-cities-es_ES.l10n.php and ES.l10n.php files

add the string in the new fields to the.po and created .mo for them

#9 @desrosj
6 months ago

  • Component changed from Build/Test Tools to Date/Time
  • Milestone changed from Awaiting Review to Future Release

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#10 @pbearne
4 months ago

  • Milestone changed from Future Release to 6.8

#11 @audrasjb
2 months ago

I added some small change requests in the PR ;)

#12 @desrosj
6 weeks ago

  • Focuses tests added

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
7 days ago

#14 @audrasjb
7 days ago

  • Owner changed from pbearne to audrasjb
  • Status changed from assigned to reviewing

Self assigning for final review and commit

Note: See TracTickets for help on using tickets.