Make WordPress Core

Opened 17 months ago

Last modified 5 months ago

#59958 new defect (bug)

Twenty Twenty: Search block is not looking proper when large size is chosen

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description (last modified by sabernhardt)

Steps to reproduce the issue :-

  1. Activate Twenty Twenty theme.
  2. Choose search block.
  3. Now change the size to large or xl

You can able to see that editor side the design not looks proper.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/CDtNRZcsTTfHClvrPfhR

Attachments (2)

2020-search-block-font-sizes-iframe.png (183.5 KB) - added by sabernhardt 17 months ago.
Search block with each font size preset (inside a post)
TT_search_block.mp4 (2.7 MB) - added by rinkalpagdar 5 months ago.

Change History (6)

@sabernhardt
17 months ago

Search block with each font size preset (inside a post)

#1 @sabernhardt
17 months ago

  • Description modified (diff)
  • Summary changed from Twenty Twenty theme - search block is not looking proper when large size is choosen. to Twenty Twenty: Search block is not looking proper when large size is chosen

In the iframe editor, the line-height for the Search label is too small when the text is large.

This shows multiple issues, which include:

  1. The Search block in the iframe editor inherits a line-height of 1.4em from wp-admin\css\common.css. Before the editor was in an iframe, the label had a normal line-height from :where(.editor-styles-wrapper) { line-height: normal; } in block-library/reset.css.
  2. The line-height in the admin styles probably should be unitless (#44643).
  3. Twenty Twenty's button styles do not apply to the Search button within the editor (with or without the iframe).
  4. In the Extra large example (and possibly others in different languages), the text of the Search button extends outside its borders.

#2 @karmatosed
13 months ago

  • Keywords needs-patch added

#3 @desrosj
5 months ago

  • Milestone changed from Awaiting Review to Future Release

Related: #62289.

#4 @rinkalpagdar
5 months ago

Hey there, I think the issue has now been resolved in the TT theme.
I have added a screencast for it. Please let me know if I am missing anything here.
Thanks!

Note: See TracTickets for help on using tickets.