WordPress.org
Get WordPress

Make WordPress Core

Opened 16 months ago

Closed 15 months ago

Last modified 14 months ago

#59982 closed enhancement (fixed)

Style engine: add CSS var parsing capability to fontSize and fontFamily

Reported by: ramonopoly's profile ramonopoly Owned by: isabel_brison's profile isabel_brison
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: has-patch has-unit-tests gutenberg-merge add-to-field-guide
Focuses: Cc:

Description

Syncs changes from ​WordPress/gutenberg#56528 by adding CSS var parsing capability to fontSize and fontFamily.

Change History (6)

This ticket was mentioned in ​PR #5710 on ​WordPress/wordpress-develop by ​@ramonopoly.
16 months ago #1

### What

Syncs changes from ​https://github.com/WordPress/gutenberg/pull/56528 by adding CSS var parsing capability to fontSize and fontFamily.

### Testing
Ensure that there are no regressions in block supports styles. Here is some test code:

<details>

<summary>Example block code</summary>

Heading

Paragraph

  • List
  • List
  • List

</details>

<details>

<summary>Frontend output</summary>

Heading

Paragraph

  • List
  • List
  • List

</details>

Run the tests!
npm run test:php -- --filter Tests_wpStyleEngine

Trac ticket: https://core.trac.wordpress.org/ticket/59982

#2 @isabel_brison
15 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 57253:

Editor: add CSS var parsing for fontSize and fontFamily.

Adds capability to parse CSS custom properties for fontSize and fontFamily in WP_Style_Engine.

Props ramonopoly.
Fixes #59982.

​@isabel_brison commented on ​PR #5710:
15 months ago #3

Committed in r57253.

This ticket was mentioned in ​Slack in #core by kebbet. ​View the logs.
15 months ago

#5 @joemcgill
15 months ago

  • Milestone changed from Awaiting Review to 6.5

#6 @stevenlinx
14 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.