WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#59992 new defect (bug)

Document global $locale in wp-admin/options.php

Reported by: upadalavipul's profile upadalavipul Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: 2nd-opinion
Focuses: docs, coding-standards Cc:

Description

I have review the below file code and found the we are used a global locale variable. but they do not mention in function comment. So I think we need improve function comment code.

File Names: wp-admin/options.php

Attachments (1)

59992.patch​ (378 bytes) - added by upadalavipul 2 years ago.

Download all attachments as: .zip

Change History (2)

@upadalavipul
2 years ago

#1 @sabernhardt
2 years ago

  • Focuses docs added
  • Keywords 2nd-opinion added
  • Summary changed from Docs: Improve various globals documentation, as per docblock standards. to Document global $locale in wp-admin/options.php

The $locale global is on line 347, not inside a named function with its own docblock. 59992.patch adds to the docblock for the allowed_options filter, which does not include the global variable. The comment immediately above line 347 could be good enough.

[39122] added the $locale variable (and the comment).

Note: See TracTickets for help on using tickets.