#60214 closed defect (bug) (fixed)
Fix var types of parameters in `sanitize_option_{$option}` filter
Reported by: | crstauf | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch commit |
Focuses: | docs | Cc: |
Description
The documentation is defining
$value
and$original_value
as if they were of typestring
, but they are very often of typearray
.
Reported by @gerardreches via User Contributed Notes.
Change History (7)
This ticket was mentioned in PR #5848 on WordPress/wordpress-develop by @crstauf.
9 months ago
#1
- Keywords has-patch added
#2
@
9 months ago
- Owner set to audrasjb
- Status changed from new to reviewing
Thanks for the ticket! Self assigning for review.
#3
@
9 months ago
- Keywords commit added
- Milestone changed from Awaiting Review to 6.5
- Status changed from reviewing to accepted
Using mixed
looks good to me since the value can be anything: worth not listing all possible types here.
Moving for 6.5 consideration.
@mukesh27 commented on PR #5848:
9 months ago
#4
@crstauf left one minor question for clarification. Thanks!
@audrasjb commented on PR #5848:
9 months ago
#7
Committed in https://core.trac.wordpress.org/changeset/57302
Note: See
TracTickets for help on using
tickets.
Fixes the documentation of the parameters used in
sanitize_option_{$option}
filter.Reported by
gerardreches
via User Contributed Notes.Trac ticket: https://core.trac.wordpress.org/ticket/60214