Deprecated parameter default value of unregister_setting() is not correct type

[crstauf]

The parameter callable $deprecated cannot default to an empty string. It must either default to null or the type has to be changed to callable|string.

-- Reported by gerardreches via User Contributed Notes.

The parameter callable $deprecated cannot default to an empty string. It must either default to null or the type has to be changed to callable|string.

-- Reported by gerardreches via User Contributed Notes.

Trac ticket: https://core.trac.wordpress.org/ticket/60328

[audrasjb]

Hi there, thanks for the patch.
@crstauf @gerardreches the pull request triggers some PHPUnit issues.
I think the condition if ( '' !== $deprecated ) needs to be updated to check for null. The related PHPUnit tests should probably be updated, too.

[gerardreches]

Replying to audrasjb:

Hi there, thanks for the patch.
@crstauf @gerardreches the pull request triggers some PHPUnit issues.
I think the condition if ( '' !== $deprecated ) needs to be updated to check for null. The related PHPUnit tests should probably be updated, too.

I think that for backward compatibility we should keep that condition, and then add an additional one for null:

if ( !== $deprecated && null !== $deprecated ) {

on line 2836 in option.php

[audrasjb]

Makes sense to me, just maybe replace && with || ;)

Removing needs-unit-tests since it wouldn't need any unit test update in that case.

…not correct type

Trac ticket: https://core.trac.wordpress.org/ticket/60328

[gerardreches]

Replying to audrasjb:

Makes sense to me, just maybe replace && with || ;)

Removing needs-unit-tests since it wouldn't need any unit test update in that case.

Maybe I'm a bit confused, but why || instead of &&? Aren't we trying to run what's inside the conditional if $deprecated has been set to something that is not the default value?

Closing in favor of #5959.