Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#60417 closed task (blessed) (fixed)

Add a Props Bot Action

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Props Bot is a new GitHub Action that will compile a list of contributors for a given pull request. The bot will leave a comment with a list of contributors formatted for use in both Trac SVN and GitHub.

It was built and maintained on GitHub in the WordPress/props-bot-action repository with the aim of helping committers and maintainers collect props for a given change.

Version 1 is ready, so let's merge this into trunk for testing!

Change History (9)

#2 @desrosj
6 months ago

In 57517:

Build/Test Tools: Introduce Props Bot workflow.

Props Bot is a new GitHub Action that will compile a list of contributors for a given pull request. The bot will leave a comment with a list of contributors formatted for use in both Trac SVN and GitHub.

Props dharm1025, desrosj, jorbin, jeffpaul, dd32, pento, gziolo, swissspidy, talldanwp, noisysocks, youknowriad, peterwilsoncc, joemcgill, chrisdavidmiles, wpscholar, annezazu, chanthaboune, desrosjbot.
See #60417.

#4 @desrosj
6 months ago

Post published: https://make.wordpress.org/core/2024/02/01/new-commit-message-requirements-in-git-hello-props-bot/. Going to leave this open in case any adjustments are needed.

#5 @desrosj
6 months ago

In 57523:

Build/Test Tools: Some improvements to the Props Bot workflow.

This makes a few improvements made to the Props Bot workflow:

  • The bot will no longer run on draft PRs.
  • The bot will no longer run on closed PRs.
  • The bot will no longer run when a comment is deleted (this should almost never happen).

Props mamaduka, gziolo.
See #60417.

#6 @jorbin
5 months ago

In 57544:

Build/Test Tools: Make the props bot message shorter.

The new default is a git flavored version, while Core wants the SVN flavor. This update is required after https://github.com/WordPress/props-bot-action/pull/61

Props desrosj, jorbin, noisysocks, gziolo.
See #60417.

#7 @swissspidy
5 months ago

  • Type changed from defect (bug) to task (blessed)

#8 @swissspidy
5 months ago

@desrosj Is there anything left to do here for 6.5?

#9 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

I think we can close this out.

I was hoping to merge WordPress/props-bot-action#75, but it's not critical and can be merged as a refinement any time.

I also think there also be merit for backporting. But that can also happen after 6.5.

Note: See TracTickets for help on using tickets.