Make WordPress Core

Opened 3 months ago

Last modified 3 days ago

#60673 assigned enhancement

Indicate submenu item level in admin nav menu editor and customizer nav menu editor

Reported by: joedolson's profile joedolson Owned by: rcreators's profile rcreators
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch needs-testing needs-testing-info
Focuses: accessibility, javascript Cc:


Follow up to #32728

Following the closure of #32728, both navigation menu interfaces indicate whether an item is in a submenu. It would improve the experience for screen reader users to indicate what level an item is at.

Change History (6)

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.

3 months ago

#2 @joedolson
3 months ago

  • Owner set to rcreators
  • Status changed from new to assigned

This ticket was mentioned in PR #6318 on WordPress/wordpress-develop by @rcreators.

8 weeks ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.

7 weeks ago

#5 @oglekler
3 days ago

  • Keywords needs-testing needs-testing-info added

@rcreators can you please check that patch don't need to refresh, provide screenshot and testing instructions? 🙏 This way it will be easier to understand where to look and what to expect. Thank you!

#6 @joedolson
3 days ago

@oglekler There are no visual changes in this patch; it's only changing the text passed to screen reader users.

The change, currently:

For top level menu items:
Was: [item name]. Menu item [x] of [y]
New: Edit menu item: [item name] ([type])

For sub menu items:

Was: [item name]. Sub item number [x] under [parent item].
New: Edit menu item: [name] ([type]), sub-item (level [depth])

A couple things I'd like to see change here:

1) The old sentences ended with a period; that should still be true.
2) Per the conversations on #60672, I think keeping the item position and parent name in the menu would be better.

Perhaps the new text should be more like

New: Edit [item name] ([type] menu item, [x] of [y])


New: Edit [item name] ([type] menu item, sub-item [x] of [y] at level [depth]

This provides a user with the full scope of context about where this item is located and what it is. It is verbose, but because of the ordering, a user could move on if they know there's only one item of the appropriate name.

I've shortened the edit prefix as well to account for @afercia's feedback on #60672. For voice recognition, I honestly think that the name only has a very low probability of triggering these buttons in any case; but I'm wondering if we changed the icon to the edit pencil & simplified like this whether it could be more intuitive for voice command usage. The pencil is more likely to be interpreted as 'edit', so a user might try speaking 'Edit [item name], and that would seem like a good possible compromise.

Note: See TracTickets for help on using tickets.