Make WordPress Core

Opened 13 months ago

Last modified 7 days ago

#60770 assigned enhancement

TimeZone select box compatibility with RTL directions

Reported by: farhad0's profile farhad0 Owned by: audrasjb's profile audrasjb
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.5
Component: I18N Keywords: has-patch needs-testing-info has-screenshots
Focuses: rtl, administration Cc:

Description

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

Attachments (3)

timezone-select-box-rtl-compatibility.jpg (116.6 KB) - added by farhad0 13 months ago.
timezone-select-box-rtl-compatibility-before-after
rtl_before.png (44.0 KB) - added by drysand 13 months ago.
rtl_after.png (43.1 KB) - added by drysand 13 months ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in PR #6268 on WordPress/wordpress-develop by @farhad0.


13 months ago
#1

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

Trac ticket: https://core.trac.wordpress.org/ticket/60770

---

#2 @swissspidy
13 months ago

  • Keywords needs-testing-info needs-screenshots added

@farhad0 Could you perhaps add before/after screenshots so that others looking at this ticket can better understand the problem you're trying to solve? Thanks!

@farhad0
13 months ago

timezone-select-box-rtl-compatibility-before-after

#3 @farhad0
13 months ago

  • Keywords has-screenshots added; needs-screenshots removed

@swissspidy
Hi,
Here you are
All RTL items are aligned and directed to right and other LTR items are in left

Last edited 13 months ago by farhad0 (previous) (diff)

@drysand
13 months ago

@drysand
13 months ago

#4 @drysand
13 months ago

i tested the patch and it does indeed align english text LTR and RTL text RTL, however it seems to align all the optiongroup headers LTR no matter the language

sorry about the separate images, im still getting used to trac

#5 @sabernhardt
7 days ago

#63184 was marked as a duplicate.

#6 @sabernhardt
7 days ago

  • Component changed from Administration to I18N
  • Milestone changed from Awaiting Review to 6.9
  • Owner set to audrasjb
  • Status changed from new to assigned

In RTL (fa-IR):

  • PR 6268 aligns every optgroup plus 'UTC' and all UTC offset options to the left, and the other options align right.
  • PR 8600 aligns the options for 'UTC' and the UTC offsets to the left, but all optgroup labels and most options align to the right.

I would like to consider using the same alignment for the 'UTC' optgroup and its option (I prefer both aligned left in Firefox but both on the right seems better in Chrome).

Note: See TracTickets for help on using tickets.