WordPress.org
Get WordPress

Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#60770 new enhancement

TimeZone select box compatibility with RTL directions

Reported by: farhad0's profile farhad0 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.5
Component: Administration Keywords: has-patch needs-testing-info has-screenshots
Focuses: rtl, administration Cc:

Description

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

Attachments (3)

timezone-select-box-rtl-compatibility.jpg​ (116.6 KB) - added by farhad0 9 months ago.
timezone-select-box-rtl-compatibility-before-after
rtl_before.png​ (44.0 KB) - added by drysand 9 months ago.
rtl_after.png​ (43.1 KB) - added by drysand 9 months ago.

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in ​PR #6268 on ​WordPress/wordpress-develop by ​@farhad0.
9 months ago #1

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

Trac ticket: https://core.trac.wordpress.org/ticket/60770

---

#2 @swissspidy
9 months ago

  • Keywords needs-testing-info needs-screenshots added

@farhad0 Could you perhaps add before/after screenshots so that others looking at this ticket can better understand the problem you're trying to solve? Thanks!

@farhad0
9 months ago

timezone-select-box-rtl-compatibility-before-after

#3 @farhad0
9 months ago

  • Keywords has-screenshots added; needs-screenshots removed

@swissspidy
Hi,
Here you are
All RTL items are aligned and directed to right and other LTR items are in left

Last edited 9 months ago by farhad0 (previous) (diff)

@drysand
9 months ago

@drysand
9 months ago

#4 @drysand
9 months ago

i tested the patch and it does indeed align english text LTR and RTL text RTL, however it seems to align all the optiongroup headers LTR no matter the language

sorry about the separate images, im still getting used to trac

Note: See TracTickets for help on using tickets.