Twenty Nineteen : Read More Block Text Decoration is not working properly

[pitamdey]

In the Twenty Nineteen theme when we add the Read More Block then there is no text decoration on the editor side but on the front, it is showing text decoration underlined. So it is not the same in both the end.

[pitamdey]

Editor Side

[pitamdey]

Frontend View

[pitamdey]

After applying this solution the issue is resolved

[poena]

Hi

I can reproduce the issue with the styles in the editor and front not matching. (6.6 alpha, theme version 2.8).

When the text decoration option is explicitly set to no underline, underline or strikethrough, the style works both in the editor and front because the style is inline in the style attribute. But the default does not match:
The default style for the block is to not show the underline.
The default style for the theme is to show the underline.

With the PR, all text decoration settings work, as well as the default.
The PR changes the link style of the read more on the front of the site, this is minor, but it is an unexpected change on existing sites. The link style no longer matches the original theme design, or other links in the content.

I would like to make the following change requests:

• Twenty Nineteen uses SASS. This means that any changes that are made directly to the .css files will be overwritten when the SASS files are built. CSS changes need to made in the .scss files.
• Try adding the underline to the block in the editor instead, so that the editor matches the front.
• Make sure that all text decoration settings still work after changing the editor style.

I believe this is the WordPress core editor block style that needs to be overwritten:

.wp-block-read-more:where(:not([style*=text-decoration])) {
    text-decoration: none;
}

[pitamdey]

In other's theme it is following different style like in some the default is text-decoration is underlined and in some it is none in both the side. So I am doing the changes particular for this theme only. So here is the patch that applied the changes in scss file

[karmatosed]

@pitamdey it looks like not all the recommendations of @poena have been followed into the PR can you confirm if this is the case or if you have feedback on any of those? I want to make sure you respond to each of them if possible as they were very detailed on changes requested.

[pitamdey]

Yes, I updated my patch now.
Points are :

1. I have made changes in style-editor.scss
2. Added the underline to the block in the editor instead, so that the editor matches the front.
3. This will be implemented only for Twenty Nineteen Theme

Thank You

[pitamdey]

Updated Patch

[karmatosed]

@pitamdey it looks like this patch isn't applying correctly can you please check it.

[karmatosed]

@pitamdey just looping back to this, it looks like there is an issue with the patch still. Are you able to iterate?

[pitamdey]

Updated Patch

[pitamdey]

As poena suggested to do the changes in the WordPress core. So I have added an updated patch , Kindly check if it is working for you or not