Caddy server / FrankenPHP got_url_rewrite support

[stephenmiracle]

Caddy + FrankenPHP officially supports url rewriting, but it doesn't show in WordPress permalinks due the logic in this function: got_url_rewrite. I had to create a mu plugin to get the permalink backend to show as expected (removing index.php) by creating a filter.

I would like to extend this function to allow for this setup by explicitly checking for Caddy or checking for a server value that we can set.

right now, it checks for $_GLOBALSis_nginx? or $_SERVER values in iis7 function. I'd like to see a $_SERVERhas_rewrite? flag that I can set in Caddy or add a flag for $_SERVER[SERVER_SOFTWARE] => FrankenPHP .

I have created a sample branch of my own that could implement either and would be willing to submit for review

Thanks.

[swissspidy]

Caddy support was added in r57612, which is in 6.5. Is anything else needed?

[stephenmiracle]

Ok great. So will be available in the soon upcoming release.

I took a review and this will work for Caddy but not FrankenPHP (which is built and dependent on top of Caddy). It updates the value to be "FrankenPHP" . You could consider updating vars.php to

str_contains( $_SERVER['SERVER_SOFTWARE'], 'Caddy' ) || str_contains( $_SERVER['SERVER_SOFTWARE'], 'FrankenPHP' )

Trac ticket: https://core.trac.wordpress.org/ticket/60884

[swissspidy]

Great, that sounds reasonable!

[swissspidy]

In 57923:

Permalinks: Detect FrankenPHP web server support.

Support pretty permalinks when FrankenPHP server is detected, which is built on top of Caddy. Caddy detection was added in [57612].

Props swissspidy, stephenmiracle.
Fixes #60884.

https://core.trac.wordpress.org/changeset/57923