![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#60937 closed defect (bug) (fixed)
Twenty Seventeen: Button block font weight does not change when using block Appearance setting
| Reported by: | pranitdugad | Owned by: | karmatosed |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.7 |
| Component: | Bundled Theme | Version: | 6.1 |
| Severity: | minor | Keywords: | has-screenshots has-patch needs-testing commit |
| Cc: | Focuses: | css |
Description
Hello,
I have reviewed the "Button block" and found that its appearance is not changing when we are trying to change button appearance using block setting.
Here, I have attached its video.
Issue: https://jmp.sh/361cqMJI
Environment info:
WordPress version: WordPress 6.5 running,
Theme: Twenty Seventeen
Browser: Google Chrome
Device: MacBook Air M1
OS: macOS 14.4.1 (23E224
Thanks,
Attachments (7)
Change History (23)
#2
@
2 years ago
- Focuses css added
- Keywords needs-patch added; has-patch removed
- Summary Twenty Seventeen: Button block appreance is not changing when we trying to change using block setting. → Twenty Seventeen: Button block font weight does not change when using block Appearance setting
- Version → 6.1
Removing the default font-weight would change the appearance for (almost) everyone's existing blocks.
Related: #58991 (and others mentioned there)
#3
@
2 years ago
- Keywords has-patch added; needs-patch removed
Updated Patch as per suggested in above comment.
- In Button block if no font-weight is selected, it will take default font-weight.
- In Button block if font-weight is selected, then it will add selected font-weight.
#5
@
2 years ago
- Milestone Future Release → 6.6
Moving to the next release to get testing with a hope this could be considered.
#6
@
2 years ago
Everything is fine from my end, there is no need to apply any patches.
Here is my Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.3.7
- Server: nginx/1.25.4
- Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
- Browser: Chrome 125.0.0.0
- OS: macOS
- Theme: Twenty Seventeen 3.6
- MU Plugins: None activated
- Plugins:
- FakerPress 0.6.6
- Test Reports 1.1.0
#7
@
2 years ago
- Keywords close added
- Milestone 6.6 → Future Release
It looks like in testing this has been shown to not be an issue anymore - if that is the case let's look to close this and move on from here. If we still have as an issue we absolutely can look to patch.
#8
@
2 years ago
- Milestone Future Release
- Resolution → invalid
- Status new → closed
As recommended I am going to close this now, thank you.
#9
@
2 years ago
- Keywords close removed
- Milestone → 6.7
- Resolution invalid
- Status closed → reopened
With 6.6-beta3-58441, the links for Button and Buttons blocks still have a font-weight of 800 when someone uses the Appearance block setting to try changing the weight.
60937.diff correctly would make the links inherit a custom weight from the block. However:
- The spaces for indentation should be replaced with tabs (possibly during commit).
- The Appearance weight selections are somewhat limited because the theme only has the
300,400,600and800weights for Libre Franklin.
#10
@
2 years ago
- Keywords needs-refresh added
Thank you for your testing @sabernhardt for me I do think that over having this done in commit as there are a few things I would love to have a patch refresh on this so we can test with everything. We do have time as bundled themes are being packaged separate and we can keep committing until RC, then it will just go to the right version - which is great.
#11
@
2 years ago
- Keywords needs-refresh removed
@karmatosed I have refreshed the patch with Latest Trunk.
#12
@
2 years ago
@shailu25 just confirming did you also do this as I don't see it:
The spaces for indentation should be replaced with tabs (possibly during commit).
After applying this patch , this issue is resolved