Make WordPress Core

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#60937 closed defect (bug) (fixed)

Twenty Seventeen: Button block font weight does not change when using block Appearance setting

Reported by: pranitdugad's profile pranitdugad Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: minor Version: 6.1
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit
Focuses: css Cc:

Description

Hello,
I have reviewed the "Button block" and found that its appearance is not changing when we are trying to change button appearance using block setting.
Here, I have attached its video.

Issue: https://jmp.sh/361cqMJI

Environment info:

WordPress version: WordPress 6.5 running,
Theme: Twenty Seventeen
Browser: Google Chrome
Device: MacBook Air M1
OS: macOS 14.4.1 (23E224
Thanks,

Attachments (7)

60937.patch (862 bytes) - added by pranitdugad 7 months ago.
After applying this patch , this issue is resolved
60937.diff (1.3 KB) - added by shailu25 7 months ago.
Patch Added
2017-Button-weight-editor-before.png (19.4 KB) - added by sabernhardt 5 months ago.
before patch, in editor (iframe)
2017-Button-weight-front-before.png (21.7 KB) - added by sabernhardt 5 months ago.
before patch, front end
2017-Button-weight-editor-with-patch.png (19.8 KB) - added by sabernhardt 5 months ago.
with patch applied, in editor (iframe)
2017-Button-weight-front-with-patch.png (22.0 KB) - added by sabernhardt 5 months ago.
with patch applied, on front end
60937.2.diff (1.3 KB) - added by shailu25 5 months ago.
Patch Refreshed

Download all attachments as: .zip

Change History (23)

@pranitdugad
7 months ago

After applying this patch , this issue is resolved

#1 @karmatosed
7 months ago

  • Keywords has-patch added

#2 @sabernhardt
7 months ago

  • Focuses css added
  • Keywords needs-patch added; has-patch removed
  • Summary changed from Twenty Seventeen: Button block appreance is not changing when we trying to change using block setting. to Twenty Seventeen: Button block font weight does not change when using block Appearance setting
  • Version set to 6.1

Removing the default font-weight would change the appearance for (almost) everyone's existing blocks.

Related: #58991 (and others mentioned there)

@shailu25
7 months ago

Patch Added

#3 @shailu25
7 months ago

  • Keywords has-patch added; needs-patch removed

Updated Patch as per suggested in above comment.

  • In Button block if no font-weight is selected, it will take default font-weight.
  • In Button block if font-weight is selected, then it will add selected font-weight.

#4 @karmatosed
5 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to Future Release

#5 @karmatosed
5 months ago

  • Milestone changed from Future Release to 6.6

Moving to the next release to get testing with a hope this could be considered.

#6 @hmbashar
5 months ago

Everything is fine from my end, there is no need to apply any patches.

Here is my Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 8.3.7
  • Server: nginx/1.25.4
  • Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.6
  • MU Plugins: None activated
  • Plugins:
    • FakerPress 0.6.6
    • Test Reports 1.1.0

#7 @karmatosed
5 months ago

  • Keywords close added
  • Milestone changed from 6.6 to Future Release

It looks like in testing this has been shown to not be an issue anymore - if that is the case let's look to close this and move on from here. If we still have as an issue we absolutely can look to patch.

#8 @karmatosed
5 months ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

As recommended I am going to close this now, thank you.

#9 @sabernhardt
5 months ago

  • Keywords close removed
  • Milestone set to 6.7
  • Resolution invalid deleted
  • Status changed from closed to reopened

With 6.6-beta3-58441, the links for Button and Buttons blocks still have a font-weight of 800 when someone uses the Appearance block setting to try changing the weight.

60937.diff correctly would make the links inherit a custom weight from the block. However:

  1. The spaces for indentation should be replaced with tabs (possibly during commit).
  2. The Appearance weight selections are somewhat limited because the theme only has the 300, 400, 600 and 800 weights for Libre Franklin.

@sabernhardt
5 months ago

before patch, in editor (iframe)

@sabernhardt
5 months ago

before patch, front end

@sabernhardt
5 months ago

with patch applied, in editor (iframe)

@sabernhardt
5 months ago

with patch applied, on front end

#10 @karmatosed
5 months ago

  • Keywords needs-refresh added

Thank you for your testing @sabernhardt for me I do think that over having this done in commit as there are a few things I would love to have a patch refresh on this so we can test with everything. We do have time as bundled themes are being packaged separate and we can keep committing until RC, then it will just go to the right version - which is great.

@shailu25
5 months ago

Patch Refreshed

#11 @shailu25
5 months ago

  • Keywords needs-refresh removed

@karmatosed I have refreshed the patch with Latest Trunk.

#12 @karmatosed
5 months ago

@shailu25 just confirming did you also do this as I don't see it:

The spaces for indentation should be replaced with tabs (possibly during commit).

#13 @shailu25
5 months ago

@karmatosed I have added tabs instead of space in Latest patch 60937.2

Last edited 5 months ago by shailu25 (previous) (diff)

#14 @karmatosed
5 months ago

  • Owner set to karmatosed
  • Status changed from reopened to assigned

Assigning to myself for testing.

#15 @karmatosed
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58584:

Twenty Seventeen: Fixes button block font weight not changing.

The button block appearance was not changing when using settings. This resolves that using inherit.

Props pranitdugad, sabernhardt, shailu25, hmbashar.
Fixes #60937.

#16 @karmatosed
5 months ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.