WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61115 closed enhancement (fixed)

Improve i18n for disk space health checks

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.3
Component: Site Health Keywords: has-patch
Focuses: Cc:

Description

The internationalised strings for the disk space health checks shouldn't include the actual disk space values, in case we want to change them in the future.

Change History (6)

This ticket was mentioned in ​PR #6473 on ​WordPress/wordpress-develop by ​@johnbillion.
2 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/61115

## Screenshots

https://github.com/WordPress/wordpress-develop/assets/208434/c12e7edd-8678-4b14-9f8f-25d638b7739e

https://github.com/WordPress/wordpress-develop/assets/208434/cd457b39-1141-4950-90e5-b1b91dba8534

​@johnbillion commented on ​PR #6473:
2 years ago #2

@afragen

#3 @audrasjb
2 years ago

Just to confirm: the idea is to keep the value outside of the string so we don't have a new string if we change the value, right?

#4 @johnbillion
2 years ago

That's correct.

#5 @johnbillion
2 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 58094:

Site Health: Improve the internationalisation of strings used in disk space health checks.

This allows the disk space values to be changed in the future without requiring a string change.

Props afragen, audrasjb, johnbillion

Fixes #61115

Note: See TracTickets for help on using tickets.