Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#61135 closed enhancement (fixed)

Global styles: output :root selector for CSS custom properties gutenberg and remove unused vars

Reported by: ramonopoly's profile ramonopoly Owned by: isabel_brison's profile isabel_brison
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.6
Component: Editor Keywords: has-patch has-unit-tests gutenberg-merge
Focuses: Cc:

Description (last modified by ramonopoly)

A ticket to track the synching of the following Gutenberg PRs:

Global styles: output :root selector for CSS custom properties

Changingbody to :root as the preset block selector to make it consistent with other CSS custom property blocks

Theme JSON: remove unused vars in layout class

$has_block_gap_support was only used once
$block_gap_value is immediately overwritten in the subsequent if block

Change History (7)

#2 @ramonopoly
6 months ago

  • Description modified (diff)
  • Keywords has-unit-tests gutenberg-merge added

#3 @isabel_brison
6 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 58123:

Editor: move global CSS custom properties to :root selector.

Changes the rules outputting global styles CSS custom properties to use :root instead of body, and cleans up some unused variables.

Props ramonopoly, isabel_brison.
Fixes #61135.

@isabel_brison commented on PR #6489:


6 months ago
#4

Committed in r58123.

#5 @kebbet
6 months ago

Please milestone in 6.6! @isabel_brison

#6 @isabel_brison
6 months ago

  • Milestone changed from Awaiting Review to 6.6

Ugh can't believe I missed that :facepalm: thanks @kebbet!

#7 @isabel_brison
6 months ago

  • Component changed from General to Editor
Note: See TracTickets for help on using tickets.