WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#61239 closed enhancement (fixed)

Add aspect ratio presets support via theme.json

Reported by: fabiankaegy Owned by: fabiankaegy
Priority: normal Milestone: 6.6
Component: Editor Version:
Severity: normal Keywords: gutenberg-merge has-patch
Cc: Focuses:

Description

Sync ticket for ​https://github.com/WordPress/gutenberg/pull/47271

There are several places in the block editor where Aspect Ratio options are presented to the user. It should be possible to customize the list of aspect ratio options available through theme.json

Change History (7)

This ticket was mentioned in ​PR #6567 on ​WordPress/wordpress-develop by ​@fabiankaegy.
2 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/61239

#2 @swissspidy
2 years ago

Internationalization needs to be fixed before this lands in core. See ​https://github.com/WordPress/gutenberg/issues/61767

#3 @fabiankaegy
2 years ago

Thanks @swissspidy,

I added a PR in the Gutenberg repo ​https://github.com/WordPress/gutenberg/pull/61774 to fix this.

At the same time I also updated the PR here in Core to include the update. So hopefully that should unblock this :)

#4 @fabiankaegy
2 years ago

  • Keywords gutenberg-merge added

#5 @fabiankaegy
2 years ago

@swissspidy @Mamaduka would you be able to help me get this reviewed in order to meet he 6.6 beta 1 cut off? Thanks in advance :)

​@isabel_brison commented on ​PR #6567:
2 years ago #6

Committed in r58242.

#7 @isabel_brison
2 years ago

  • Resolution → fixed
  • Status assigned → closed

https://core.trac.wordpress.org/changeset/58242 should close this ticket but I forgot to add the ticket number :facepalm:

Note: See TracTickets for help on using tickets.