Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

#61306 closed defect (bug) (fixed)

Twenty Sixteen: pre element has less padding in the editor

Reported by: pranitdugad's profile pranitdugad Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: 4.8
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: css Cc:

Description

In theme Twenty Sixteen, the verse block has different padding on frontend and backend.

Attachments (5)

Screenshot 2024-05-28 at 9.36.11 AM.png (86.0 KB) - added by pranitdugad 5 weeks ago.
I have attached screenshot for better Understanding
Screenshot 2024-05-28 at 9.35.32 AM.png (76.7 KB) - added by pranitdugad 5 weeks ago.
61306.patch (561 bytes) - added by pranitdugad 5 weeks ago.
this is due different padding in pre tag for editor and frontend.
61306.2.patch (561 bytes) - added by pranitdugad 5 weeks ago.
this is due different padding in pre tag for editor and frontend. After applying this patch this issue is resolved
61306.3.patch (478 bytes) - added by sabernhardt 5 weeks ago.
corrects pre padding in editor-style.css

Download all attachments as: .zip

Change History (15)

@pranitdugad
5 weeks ago

I have attached screenshot for better Understanding

@pranitdugad
5 weeks ago

this is due different padding in pre tag for editor and frontend.

@pranitdugad
5 weeks ago

this is due different padding in pre tag for editor and frontend. After applying this patch this issue is resolved

This ticket was mentioned in Slack in #core-test by ankit-k-gupta. View the logs.


5 weeks ago

#2 @sumitsingh
5 weeks ago

  • Keywords has-patch needs-testing added

#3 @sumitbagthariya16
5 weeks ago

Test report ✅

I have tested the patch below and it is working as expected.

https://core.trac.wordpress.org/attachment/ticket/61306/61306.patch

Environment

OS: macOS Ventura 13.3
Web Server: Nginx
PHP: 8.0
WordPress: 6.5.3
Browser: Chrome
Theme: Twenty Sixteen - 3.2

Backend:
https://prnt.sc/mYag5oNH0VY5

Front End:
https://prnt.sc/CARfDvTZC1Ek

Last edited 5 weeks ago by sumitbagthariya16 (previous) (diff)

#4 @Hitendra Chopda
5 weeks ago

Test report

I have tested the patch below and it is working as expected.

https://core.trac.wordpress.org/attachment/ticket/61306/61306.3.patch

Environment

OS: macOS Sonoma 14.4
Web Server: Nginx
PHP: 8.0
WordPress: 6.6-alpha-58220
Browser: Safari 7.4 (macOS), Chrome Version 123.0.6312.106
Theme: Twenty Sixteen - 3.2

Screenshot: https://share.cleanshot.com/nKhQSwk7p1t8NqSmYtH4

Actual Result:

After applying the patch, the padding will be displayed the same on both sides.

Thank you.

Last edited 5 weeks ago by Hitendra Chopda (previous) (diff)

@sabernhardt
5 weeks ago

corrects pre padding in editor-style.css

#5 @sabernhardt
5 weeks ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 6.6
  • Summary changed from Twenty Sixteen : Verse Block Padding is not same in frontend to Twenty Sixteen: pre element has less padding in the editor
  • Version set to 4.8

The pre element has had a padding of 1.75em on the front end since the first version (even in the initial commit). The editor needs to reflect that.

#6 @huzaifaalmesbah
5 weeks ago

Test Report

Description

Patch tested: 61306.3.patch Thanks For the Patch @sabernhardt.

Adjusted the pre element padding to 1.75em on both sides and resolved the issue with a patch.

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 8.3.6
  • Server: nginx/1.25.5
  • Database: mysqli (Server: 11.3.2-MariaDB / Client: mysqlnd 8.3.6)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.2
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Screenshots

After Apply Patch Editor After Apply Patch Frontend
https://i.ibb.co/ZBzWKYT/Huzaifa-20240528203836.png https://i.ibb.co/4VnLtGF/Huzaifa-20240528203844.png
Last edited 5 weeks ago by huzaifaalmesbah (previous) (diff)

#7 @shuvomohajan
5 weeks ago

Test Report

Description

The patch successfully addresses the padding inconsistency for the pre element in the Twenty Sixteen theme editor.

Patch tested: 61306.3.patch

Environment

  • WordPress: 6.6-alpha-58220
  • PHP: 8.0.30-dev
  • Server: PHP.wasm
  • Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
  • Browser: Chrome 125.0.0.0
  • OS: Linux
  • Theme: Twenty Sixteen 3.2
  • MU Plugins:
    • 0-sqlite.php
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Befor apply patch

Editor Frontend
https://i.postimg.cc/DzcySnLn/Screenshot-from-2024-05-28-22-46-20.png https://i.postimg.cc/wMm1yD0m/Screenshot-from-2024-05-28-22-00-17.png

After apply patch

Editor Frontend
https://i.postimg.cc/qgHz8g5Z/Screenshot-from-2024-05-28-22-00-04.png https://i.postimg.cc/wMm1yD0m/Screenshot-from-2024-05-28-22-00-17.png
Last edited 5 weeks ago by shuvomohajan (previous) (diff)

#8 @hmbashar
5 weeks ago

Test Report

Patch tested: 61306.3.patch

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 8.3.7
  • Server: nginx/1.25.4
  • Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.2
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Before

Editor Frontend
https://i.ibb.co/QFYKGvk/before-backend.png https://i.ibb.co/TBVN4rm/Before-Frontend.png

After

Editor Frontend
https://i.ibb.co/XzSB0bV/After-Backend.png https://i.ibb.co/QKPLfrF/After-Front-End.png
Last edited 5 weeks ago by hmbashar (previous) (diff)

#9 @karmatosed
5 weeks ago

  • Keywords commit added; needs-testing removed

#10 @karmatosed
5 weeks ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 58239:

Twenty Sixteen: Fixes pre element having less padding in the editor.

The verse block has different padding between editor and frontend.

Props pranitdugad, sumitsingh, sumitbagthariya16, hitendra-chopda, sabernhardt, huzaifaalmesbah, shuvomohajan, hmbashar.
Fixes #61306.

Note: See TracTickets for help on using tickets.