Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#61316 closed enhancement (fixed)

Directories and Sizes label should have translation comment that Sizes also related to db

Reported by: oglekler's profile oglekler Owned by: afragen's profile afragen
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.6
Component: Site Health Keywords: has-patch commit
Focuses: docs Cc:

Description

I found that we have a slightly incorrect translation into Russian that means: "Directories and their sizes", because it isn't clear what sizes are. So, it looks like we need longer label to explain things, but I can only come up with "Directories, database and storage sizes" and question about changing the label could turn into a long discussion, so I suggest:

	if ( ! $is_multisite ) {
		$info['wp-paths-sizes'] = array(
			/* translators: Database and storage sizes included */
			'label'  => __( 'Directories and Sizes' ),
			'fields' => array(),
		);
	}

Attachments (1)

patch.diff (497 bytes) - added by amitraj2203 5 months ago.
Patch file

Download all attachments as: .zip

Change History (9)

@amitraj2203
5 months ago

Patch file

#1 @amitraj2203
5 months ago

  • Keywords has-patch added

Hi @oglekler, according to your suggestion I have submitted the patch for it.

#2 follow-up: @oglekler
5 months ago

@afragen Can you take a look, please? This is quite a small change.

#3 in reply to: ↑ 2 @afragen
5 months ago

Replying to oglekler:

@afragen Can you take a look, please? This is quite a small change.

Will do.

#4 @afragen
5 months ago

For some reason my PR isn't showing up. https://github.com/WordPress/wordpress-develop/pull/6715

Last edited 5 months ago by afragen (previous) (diff)

This ticket was mentioned in PR #6715 on WordPress/wordpress-develop by @afragen.


5 months ago
#5

Add a translators comment to debug data for Directories and Sizes on class-wp-debug-data.php.

PIng @OlaIola

#6 @afragen
5 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.6
  • Owner set to afragen
  • Status changed from new to assigned
  • Version set to trunk

#7 @costdev
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58307:

Site Health: Add translator comment to explain Directories and Sizes.

This adds a translator comment to the Site Health's debug data to describe what "Directories and Sizes" refers to.

References:

Props oglekler, afragen, amitraj2203.
Fixes #61316.

@costdev commented on PR #6715:


5 months ago
#8

Committed in r58307.

Note: See TracTickets for help on using tickets.