Bundled block themes: The theme.json schema version is incorrect

[poena]

Both Twenty Twenty-Two, Twenty Twenty-Three, and Twenty Twenty-Four uses
"$schema": "https://schemas.wp.org/trunk/theme.json", in theme.json.

However, trunk is the development version.
Because this schema has already been updated in preparation for the theme.json version bump from 2 to 3 in WordPress 6.6, code editors show parts of theme.json as invalid.

The themes need to use the version of theme.json that was valid when the theme was released.

Documentation:
​https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-v2/#json-schema

The last schema for version 2 is available at https://schemas.wp.org/wp/6.5/theme.json.

[sabernhardt]

The three bundled themes will need correcting, but ​more than 300 other themes might break with the version bump because they followed our example.

[wildworks]

I remember this issue being discussed in the PR where the theme.json version was bumped up to 3 on the Gutenberg plugin (See this comment: ​https://github.com/WordPress/gutenberg/pull/58409#discussion_r1584277338).

@ajlende do you have any good ideas to deal with this issue?

Trac ticket:
https://core.trac.wordpress.org/ticket/61342

[poena]

Testing instructions

Apply the PR and open the theme.json files in a code editor that supports using the schema for validation. There should be no problems reported.

[poena]

Replying to sabernhardt:

The three bundled themes will need correcting, but ​more than 300 other themes might break with the version bump because they followed our example.

It is only the validation of the file, when it is viewed in a supported code editor, that shows incorrect warnings. The theme does not break in other ways.

[mukesh27]

Q: Do we needs to update the WP version based on release in theme.json?

[poena]

Replying to mukesh27:

Q: Do we needs to update the WP version based on release in theme.json?

I am not sure I understand the question.
Are you asking if Twenty Twenty-Two, that has a minimum required WP version of 5.9,
should have https://schemas.wp.org/wp/5.9/theme.json?

I don't think so.
Version 2 of theme.json is used from WordPress 5.9 to 6.5.
There are no breaking changes in version 2, only new features added in different WordPress versions.
Using the 5.9 schema would show that appearanceTools and FontFace are not valid.

[kafleg]

Thank you for making the ticket @poena

I tested by changing it and the issue was gone. :)

I changed trunk to wp/6.5 in this line "$schema": "https://schemas.wp.org/wp/6.5/theme.json",

Thank you

[audrasjb]

The PR looks good to me too.
Marking for commit.

[audrasjb]

In 58403:

Bundled block themes: Set theme.json schema version to 6.5.

This changeset updates the theme.json schema version from trunk which is the development version to the last schema for version 2 available at https://schemas.wp.org/wp/6.5/theme.json.

Props poena, sabernhardt, wildworks, mukesh27, kafleg.
Fixes #61342.

committed in https://core.trac.wordpress.org/changeset/58403

[poena]

The schema was not update in the style variation files.

In Twenty Twenty-Two, the schema is missing:
https://core.trac.wordpress.org/browser/branches/6.6/src/wp-content/themes/twentytwentytwo/styles/blue.json

In Twenty Twenty-Three and four, the schema version is trunk:
https://core.trac.wordpress.org/browser/branches/6.6/src/wp-content/themes/twentytwentythree/styles/aubergine.json

https://core.trac.wordpress.org/browser/branches/6.6/src/wp-content/themes/twentytwentyfour/styles/ember.json

Can this ticket be reopened or do I need to create a new?

[karmatosed]

@poena I feel like creating a new ticket makes sense as this one has passed but also wouldn't fight it being reopened.

[SergeyBiryukov]

Follow-up: #61789