Make WordPress Core

Opened 6 weeks ago

Last modified 4 weeks ago

#61393 new defect (bug)

Trailing Slash Issue in Category Pagination URLs with the_posts_pagination()

Reported by: hmbashar's profile hmbashar Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Permalinks Keywords: has-screenshots has-patch has-testing-info needs-testing changes-requested needs-unit-tests
Focuses: Cc:

Description

Hello,

I've checked a few themes that use the the_posts_pagination() function for pagination, and I think this function has a small issue. Although it’s not a major problem, it should still be addressed. If I remove the extra/trailing slash (/) at the end of the URL from the permalink structure (like /%%postname%% instead of /%%postname%%/), it works perfectly for all category pages except the first page.

For example, if I have a category slug "uncategorized", the pagination for this category archive page works as follows:

However, if I hover over any other number in the pagination, it shows without the trailing slash (/). Check this screenshot: https://prnt.sc/GICqVaCdAD8e. But if I hover over page number 1, it shows with a trailing slash, like this: https://wpdevelop.test/category/uncategorized/. Check this screenshot: https://prnt.sc/n-eNn-P_Zr5x. After clicking on page number 1, it redirects to the URL without the slash: https://wpdevelop.test/category/uncategorized.

So, I think if it redirects to remove the slash, the URL should also remove the slash when hovering over page number 1.

I've checked several themes with this behavior:

  • Twenty Fifteen Version: 3.7
  • Twenty Fourteen Version: 3.9
  • Twenty Nineteen Version: 2.8
  • Twenty Seventeen Version: 3.6
  • Twenty Sixteen Version: 3.2
  • Twenty Twenty Version: 2.6
  • Twenty Twenty-One Version: 2.2
  • Twenty Twenty-Two Version: 1.7
  • Astra Version: 4.7.0

How to Check the Issue:

  1. Activate any of the themes mentioned above.
  2. Add categories.
  3. Add a few posts with those categories to enable pagination.
  4. Set permalinks with a custom structure (/%%postname%%), ensuring you don’t include a slash at the end.
  5. Visit your category archive, e.g., https://wpdevelop.test/category/uncategorized.
  6. Click pagination numbers and check the URLs.

Check the screenshots for reference:

Thank you!

Attachments (11)

Permalink structure set.png (186.6 KB) - added by hmbashar 6 weeks ago.
others pagination view.png (148.2 KB) - added by hmbashar 6 weeks ago.
First Page Pagination view.png (116.9 KB) - added by hmbashar 6 weeks ago.
Trailing Slash Issue in Category Pagination URLs with the_posts_pagination().mp4 (9.7 MB) - added by hmbashar 6 weeks ago.
I've added a video you may watch this from here for you can download from the attachment https://www.berrycast.com/conversations/88000375-7f49-574e-9ba0-e338ffc63702
61393.diff (645 bytes) - added by rahulsprajapati 5 weeks ago.
Use user_trailingslashit to fix trailing slash issue in pagination permalink.
61393-non-trailslash-permalink.gif (2.5 MB) - added by rahulsprajapati 5 weeks ago.
Test GIF: When removed trailingslash from permalink structure it uses all link without trailslash.
61393-with-trailslash-permalink.gif (1.5 MB) - added by rahulsprajapati 5 weeks ago.
Test GIF: When using trailingslash in permalink structure it uses all link with trailslash.
Huzaifa-20240613230120.gif (8.3 MB) - added by huzaifaalmesbah 5 weeks ago.
I test 61393.diff Working and looks good for me.
Screenshot at Jun 13 11-47-40 PM.png (161.7 KB) - added by hmbashar 5 weeks ago.
I've tested the patch 61393.diff, and it's working for me. The issue has been resolved.
61393-1.diff (1.2 KB) - added by rahulsprajapati 5 weeks ago.
Use user_trailingslashit to fix trailing slash issue in pagination permalink including "Newest Post" and "Older Post" links.
Screenshot at Jun 14 12-28-39 AM.png (189.1 KB) - added by hmbashar 5 weeks ago.
Perfect with the patch "61393-1.diff, I think now everything's is fine.

Change History (23)

#1 @huzaifaalmesbah
6 weeks ago

Thank you @hmbashar for pointing out this valid issue. I have been able to reproduce it.

In my tests with the default WordPress theme, as well as popular themes like Astra, GeneratePress, and Neve, I observed that they all encounter the same trailing slash issue when using the the_posts_pagination() function.


#2 @rejaulalomkhan
6 weeks ago

Thank you for thoroughly documenting this issue.
Following your detailed instructions, I successfully reproduced the problem.

This issue has significant implications for our SEO performance, potentially affecting our site's visibility and traffic.
A prompt resolution is essential to mitigate these risks. Please prioritize addressing this to prevent any negative impact on our search engine rankings.
Your swift attention to this matter is greatly appreciated.🙏

Last edited 6 weeks ago by rejaulalomkhan (previous) (diff)

This ticket was mentioned in Slack in #accessibility by hmbashar. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core-test by mai21. View the logs.


5 weeks ago

#5 @mai21
5 weeks ago

@hmbashar thanks for reporting the issue.

Reproduction Report

Description

This report validates that the issue can be reproduced.

Steps

As mentioned on the main ticket

Environment

  • WordPress: 6.6-beta2-58396
  • PHP: 8.3.6
  • Server: nginx/1.24.0
  • Database: mysqli (Server: 10.5.24-MariaDB-1:10.5.24+maria~ubu2004-log / Client: mysqlnd 8.3.6)
  • Browser: Chrome 125.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.6
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0
    • WordPress Beta Tester 3.5.5

Actual Results

🐞 Error condition occurs. Hovering the 1st-page link will have /, however, when clicked it opens the link without / (reproduced).

Expected Result

✅ Hovering any page (1st or nth) link shall match permalinks either it was with/without trailing slash

@rahulsprajapati
5 weeks ago

Use user_trailingslashit to fix trailing slash issue in pagination permalink.

@rahulsprajapati
5 weeks ago

Test GIF: When removed trailingslash from permalink structure it uses all link without trailslash.

@rahulsprajapati
5 weeks ago

Test GIF: When using trailingslash in permalink structure it uses all link with trailslash.

#6 @rahulsprajapati
5 weeks ago

  • Keywords has-patch added; needs-patch removed

Added patch & gifs for test permalink with and without trailingslash in pagination links.

@huzaifaalmesbah
5 weeks ago

I test 61393.diff Working and looks good for me.

#7 @huzaifaalmesbah
5 weeks ago

  • Keywords has-testing-info needs-testing added

according to the ticket status, I added two keywords has-testing-info and needs-testing

@hmbashar
5 weeks ago

I've tested the patch 61393.diff, and it's working for me. The issue has been resolved.

#8 @hmbashar
5 weeks ago

  • Keywords changes-requested added

Hello @rahulsprajapati,

I've tested your patch, and while it is working fine, I have noticed another issue. Perhaps your patch could address this as well. I checked several themes like Astra, Twenty Fifteen, Twenty Fourteen, and more. I observed that themes with the "Newest Post" and "Older Post" navigation feature have a trailing slash for the newest posts (see screenshot). However, other themes with the same features, such as Twenty Eleven and Twenty Ten, do not show a trailing slash with the newest posts (see screenshots).

Twenty Fourteen: https://prnt.sc/NrC_xTz4b63X
Astra: https://prnt.sc/i2H72Q6XLBjc
Twenty Fifteen: https://prnt.sc/bawBT2J-IhM7

Twenty Ten: https://prnt.sc/lTizkhfzP-Uz
Twenty Eleven: https://prnt.sc/iv169bWJkQSz

@rahulsprajapati
5 weeks ago

Use user_trailingslashit to fix trailing slash issue in pagination permalink including "Newest Post" and "Older Post" links.

#9 @rahulsprajapati
5 weeks ago

Hello @hmbashar,

Thank you for testing this and for the feedback. I just uploaded another patch with the next and prev link fix. Let me know if you see any issue with this.

@hmbashar
5 weeks ago

Perfect with the patch "61393-1.diff, I think now everything's is fine.

This ticket was mentioned in Slack in #core-test by hmbashar. View the logs.


5 weeks ago

#11 @martin.krcho
5 weeks ago

  • Keywords needs-unit-tests added

#12 @joedolson
4 weeks ago

  • Focuses accessibility removed

I don't see anything about this that impacts accessibility; removing the focus.

Note: See TracTickets for help on using tickets.