Context Navigation

← Previous Ticket
Next Ticket →

#61456 closed defect (bug) (fixed)

Taxonomy: Unused variable in `wp_set_object_terms()`

Reported by:	dlh	Owned by:	costdev
Priority:	normal	Milestone:	6.6
Component:	Taxonomy	Version:	2.3
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description (last modified by costdev)

In [5983], a call to clean_term_cache() was removed from wp_set_object_terms(). Since then, the $term_ids array that had been passed to clean_term_cache() has been populated inside one of the foreach loops but never used.

Change History (6)

This ticket was mentioned in PR #6846 on WordPress/wordpress-develop by @dlh.

2 years ago #1

Keywords has-patch added

#2 @mukesh27
2 years ago

Keywords commit added
Milestone Awaiting Review → 6.6

Hi there!

Thanks for the patch!

Look good to me and ready for commit for 6.6

#3 @costdev
2 years ago

Description modified (diff)

#4 @costdev
2 years ago

Owner set to costdev
Status new → assigned

#5 @costdev
2 years ago

Resolution → fixed
Status assigned → closed

In 58427:

Taxonomy: Remove unused $term_ids in wp_set_object_terms().

In [5983], a call to clean_term_cache() was removed from wp_set_object_terms(). Since then, the $term_ids array that had been populated inside one of the foreach loops before being passed to the removed clean_term_cache() call has not been used.

This change removes the unused $term_ids variable.

Follow-up to [5983].

Props dlh, mukesh27.
Fixes #61456.

@costdev commented on PR #6846:

2 years ago #6

Nice catch and thanks for the PR @dlh01! Committed in r58427.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#61456 closed defect (bug) (fixed)

Taxonomy: Unused variable in `wp_set_object_terms()`

Description (last modified by costdev)

Change History (6)

This ticket was mentioned in ​PR #6846 on ​WordPress/wordpress-develop by ​@dlh. 2 years ago #1

#2 @mukesh27 2 years ago

#3 @costdev 2 years ago

#4 @costdev 2 years ago

#5 @costdev 2 years ago

​@costdev commented on ​PR #6846: 2 years ago #6