New plugins list item breaks if WP version is incompatible

[wojtekn]

The plugin list layout becomes broken when there is a plugin found that is incompatible with a current WordPress version. For example:

1. Install WordPress 6.4.3
2. Navigate to Plugins -> Add New Plugin
3. Search for Create Block Theme

It's caused by printf used instead of sprintf in the code that generates that block.

Trac ticket: https://core.trac.wordpress.org/ticket/61465

[sabernhardt]

broken message for plugin that requires newer WordPress version (using 6.4.3 and plugin requires 6.5)

[sabernhardt]

Hi and thanks for the ticket and patch!

[56571] missed updating that message fragment to sprintf. (I did not find any other = printf results when searching in wp-admin or wp-includes.) "86" in the error message apparently was the string length for the link.

To test the patch in trunk, you could replace is_wp_version_compatible (currently on line 553):
$compatible_wp = false;

[wojtekn]

"86" in the error message apparently was the string length for the link.

Nice TIL! I was wondering where this number comes from, but I didn't explore this part further. It seems that ​https://www.php.net/manual/en/function.printf.php in addition to outputting string, returns string length as int:

Returns the length of the outputted string.

[rajinsharwar]

I have tested the fix PR 6858
Before: ​https://prnt.sc/GbssKMU4jNyq
After: ​https://prnt.sc/3LA95_j6sFVj

The patch is working as expected. ✅

[SergeyBiryukov]

In 58446:

Plugins: Correct plugin card layout when incompatible plugin message is displayed.

This replaces an erroneous printf() call with sprintf() that was missed when updating this fragment to use wp_admin_notice().

Follow-up to [56571].

Props wojtekn, sabernhardt, rajinsharwar.
Fixes #61465.

Thanks for the PR! Merged in r58446.

[ocean90]

#61848 was marked as a duplicate.