![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#61507 closed defect (bug) (fixed)
Twenty Nineteen: Fix font size and citation display for Pullquote block
| Reported by: | pitamdey | Owned by: | karmatosed |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.7 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-screenshots has-patch commit |
| Cc: | Focuses: | css |
Description
In Theme Twenty Nineteen, Pullquote Block Text Decoration is not reflecting in frontend for citation but working fine in editor side
I have attached a screenshot for reference
Attachments (5)
Change History (13)
This ticket was mentioned in PR #6913 on WordPress/wordpress-develop by @narenin.
2 years ago
#2
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/61507
@
2 years ago
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
This ticket was mentioned in PR #6945 on WordPress/wordpress-develop by @sabernhardt.
2 years ago
#3
- Restores the default Pullquote paragraph font size to 49.5 (2.25em * 22px), which has been multiplied by 1.5 since WordPress 6.1.
- Sets the
citeelement todisplay: blockfor consistent spacing andtext-decoration.
@sabernhardt commented on PR #6945:
2 years ago
#4
Before patch: front end has extra-large font size, and the Pullquote does not honor the underline setting on the citation.
With patch: front end would reset the block's font size so the paragraph is 2.25em again, and the citation includes the underline according to the block option.
Editor with patch (which is the same as before):
Spacing comparison for citations of different lengths:
- Before patch, a one-line citation has more space above it than a citation that wraps to a second line.
- With the patch, both one-line and two-line citations have the same amount of space between them and the Pullquote paragraph.
Full images with each text decoration option:
- Front end before patch
- Front end with patch
- The editor displays these blocks the same way both before and after
#5
@
2 years ago
- Focuses css added
- Keywords needs-testing added
- Milestone Awaiting Review → Future Release
- Summary Twenty Nineteen : Pullquote Block Text Decoration is not reflecting in frontend for citation → Twenty Nineteen: Fix font size and citation display for Pullquote block
The font size is not directly related to the display property, but I wanted both to be fixed together.
PR 6945 includes the Sass and the two compiled stylesheets.
Editor View