Make WordPress Core

Opened 4 weeks ago

Closed 3 weeks ago

Last modified 9 days ago

#61507 closed defect (bug) (fixed)

Twenty Nineteen: Fix font size and citation display for Pullquote block

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: css Cc:

Description

In Theme Twenty Nineteen, Pullquote Block Text Decoration is not reflecting in frontend for citation but working fine in editor side
I have attached a screenshot for reference

Attachments (5)

Screenshot 2024-06-26 at 3.24.27 PM.png (210.0 KB) - added by pitamdey 4 weeks ago.
Editor View
Screenshot 2024-06-26 at 3.24.38 PM.png (145.4 KB) - added by pitamdey 4 weeks ago.
Frontend View
61507.patch (603 bytes) - added by viralsampat 4 weeks ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
pullquote-after-resolve-editor-side.png (420.3 KB) - added by viralsampat 4 weeks ago.
After resolved issue Back-end:
pullquote-after-resolve-front-end-side.png (335.8 KB) - added by viralsampat 4 weeks ago.
After resolved issue front-end:

Download all attachments as: .zip

Change History (13)

This ticket was mentioned in PR #6913 on WordPress/wordpress-develop by @narenin.


4 weeks ago
#2

  • Keywords has-patch added

@viralsampat
4 weeks ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
4 weeks ago

After resolved issue Back-end:

@viralsampat
4 weeks ago

After resolved issue front-end:

This ticket was mentioned in PR #6945 on WordPress/wordpress-develop by @sabernhardt.


3 weeks ago
#3

  • Restores the default Pullquote paragraph font size to 49.5 (2.25em * 22px), which has been multiplied by 1.5 since WordPress 6.1.
  • Sets the cite element to display: block for consistent spacing and text-decoration.

Trac 61507

@sabernhardt commented on PR #6945:


3 weeks ago
#4

Before patch: front end has extra-large font size, and the Pullquote does not honor the underline setting on the citation.

https://github.com/WordPress/wordpress-develop/assets/17100257/ecb4014d-8922-4628-b3a2-8aa234886df6

With patch: front end would reset the block's font size so the paragraph is 2.25em again, and the citation includes the underline according to the block option.

https://github.com/WordPress/wordpress-develop/assets/17100257/565bbf14-39b1-485c-b6c6-57cdaae8a4ee

Editor with patch (which is the same as before):
https://github.com/WordPress/wordpress-develop/assets/17100257/ea48695a-e3d8-4ba0-8588-de974a59cd33

Spacing comparison for citations of different lengths:

  • Before patch, a one-line citation has more space above it than a citation that wraps to a second line.
  • With the patch, both one-line and two-line citations have the same amount of space between them and the Pullquote paragraph.

https://github.com/WordPress/wordpress-develop/assets/17100257/ba375daa-1d57-4588-8f31-d2000365a790

Full images with each text decoration option:

#5 @sabernhardt
3 weeks ago

  • Focuses css added
  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Nineteen : Pullquote Block Text Decoration is not reflecting in frontend for citation to Twenty Nineteen: Fix font size and citation display for Pullquote block

The font size is not directly related to the display property, but I wanted both to be fixed together.

PR 6945 includes the Sass and the two compiled stylesheets.

#6 @karmatosed
3 weeks ago

  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to assign this to myself to test and see what can be done about looking to commit this. Thanks.

#7 @karmatosed
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58630:

Twenty Nineteen: Fixes font size and citation display for Pullquote block.

The pullquote block text decoration was not the same front and within the editor. This resolves that and resets.

Props pitamdey, viralsampat, sabernhardt.
Fixes #61507.

#8 @karmatosed
3 weeks ago

  • Keywords commit added

#9 @sabernhardt
9 days ago

  • Keywords needs-testing removed
  • Milestone changed from Future Release to 6.7
Note: See TracTickets for help on using tickets.