Make WordPress Core

Opened 6 weeks ago

Closed 3 weeks ago

#61795 closed defect (bug) (invalid)

Lighthouse shows invalid ARIA role error for role="group"

Reported by: dilipbheda's profile dilipbheda Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch has-testing-info close
Focuses: ui, accessibility Cc:

Description

I've found the Accessibility role error in the admin bar.
Ref: https://tinyurl.com/2cp6mj4c

As per the ARIA docs suggestion, we can fix it by adding a none role in the li tag.
Docs: https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role

Attachments (1)

61795.patch (621 bytes) - added by dilipbheda 6 weeks ago.

Download all attachments as: .zip

Change History (6)

@dilipbheda
6 weeks ago

#1 @narenin
6 weeks ago

  • Keywords has-testing-info added

Test Report

I have tested latest patch and it is working as expected. https://core.trac.wordpress.org/attachment/ticket/61795/61795.patch

Environment

WordPress: 6.7-alpha-58576-src
PHP: 8.1.23
Server: nginx/1.16.0
Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
Browser: Chrome 126.0.0.0 (macOS)
Theme: Twenty Twenty Version: 2.7

Expected Results

✅ Aria role error has been fixed.

Screenshot (Before Patch) - https://prnt.sc/ys7Sq7EI92PX
Screenshot (After Patch) - https://prnt.sc/34-zMvx9-wVn

#2 @sabernhardt
6 weeks ago

  • Component changed from Administration to Toolbar
  • Summary changed from Accessibility: Lighthouse show in valid ARIA role error. to Lighthouse shows invalid ARIA role error for role="group"

Related: #60919

#3 @joedolson
5 weeks ago

  • Keywords close added

The test in Lighthouse is incorrect; the group role is permitted on list items as long as the parent list does *not* have the list role. The parent node in this case is a ul with role="menu", so it is correct.

This is correct per the HTML ARIA specifications for `li`.

Recommend closing.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


3 weeks ago

#5 @joedolson
3 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing as invalid following discussion in the accessibility bug scrub.

Note: See TracTickets for help on using tickets.