Make WordPress Core

Opened 13 months ago

Closed 12 months ago

Last modified 6 days ago

#61795 closed defect (bug) (invalid)

Lighthouse shows invalid ARIA role error for role="group"

Reported by: dilipbheda's profile dilipbheda Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch has-test-info close
Focuses: ui, accessibility Cc:

Description

I've found the Accessibility role error in the admin bar.
Ref: https://tinyurl.com/2cp6mj4c

As per the ARIA docs suggestion, we can fix it by adding a none role in the li tag.
Docs: https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role

Attachments (1)

61795.patch (621 bytes) - added by dilipbheda 13 months ago.

Download all attachments as: .zip

Change History (11)

@dilipbheda
13 months ago

#1 @narenin
13 months ago

  • Keywords has-testing-info added

Test Report

I have tested latest patch and it is working as expected. https://core.trac.wordpress.org/attachment/ticket/61795/61795.patch

Environment

WordPress: 6.7-alpha-58576-src
PHP: 8.1.23
Server: nginx/1.16.0
Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
Browser: Chrome 126.0.0.0 (macOS)
Theme: Twenty Twenty Version: 2.7

Expected Results

✅ Aria role error has been fixed.

Screenshot (Before Patch) - https://prnt.sc/ys7Sq7EI92PX
Screenshot (After Patch) - https://prnt.sc/34-zMvx9-wVn

#2 @sabernhardt
13 months ago

  • Component changed from Administration to Toolbar
  • Summary changed from Accessibility: Lighthouse show in valid ARIA role error. to Lighthouse shows invalid ARIA role error for role="group"

Related: #60919

#3 @joedolson
12 months ago

  • Keywords close added

The test in Lighthouse is incorrect; the group role is permitted on list items as long as the parent list does *not* have the list role. The parent node in this case is a ul with role="menu", so it is correct.

This is correct per the HTML ARIA specifications for `li`.

Recommend closing.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


12 months ago

#5 @joedolson
12 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing as invalid following discussion in the accessibility bug scrub.

#6 @phatakraj
8 months ago

I recently face this, but as read above mentioned. Now How to fix this? Is this forum closed?

Last edited 3 months ago by phatakraj (previous) (diff)

#7 @joedolson
8 months ago

You're welcome to make comments if you believe that this is a problem that needs to be addressed. However, we're not going to remove existing semantics just because some testing tools incorrectly register this as an error.

#8 @wordpressdotorg
3 months ago

  • Keywords has-test-info added; has-testing-info removed

#9 @joedolson
2 months ago

#63542 was marked as a duplicate.

#10 @yanshgupta
13 days ago

Thank you for the clarification. I completely understand the reasoning behind keeping the current semantics. That said, I’ve also encountered the same ARIA role error in my environment, particularly in the admin bar. Just wanted to share in case it’s helpful for ongoing accessibility considerations. Appreciate the team's attention to detail!

Last edited 6 days ago by yanshgupta (previous) (diff)
Note: See TracTickets for help on using tickets.