Make WordPress Core

Opened 8 weeks ago

Closed 8 weeks ago

Last modified 8 weeks ago

#61846 closed defect (bug) (fixed)

Twenty Twelve: Button block Outline style has the wrong text color on the front

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.6
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit
Focuses: css Cc:

Description

In theme Twenty Twelve, Button blocks have different text color in the editor & frontend side

Attachments (4)

Screenshot 2024-08-09 at 10.44.03 AM.png (205.1 KB) - added by pitamdey 8 weeks ago.
Editor View
Screenshot 2024-08-09 at 10.44.23 AM.png (221.8 KB) - added by pitamdey 8 weeks ago.
Frontend View
61846.patch (473 bytes) - added by pitamdey 8 weeks ago.
after applying this solution the issue is resolved
61846.1.patch (593 bytes) - added by sabernhardt 8 weeks ago.
sets Outline style text color to currentColor in theme's blocks.css stylesheet

Download all attachments as: .zip

Change History (9)

@pitamdey
8 weeks ago

after applying this solution the issue is resolved

#1 @ugyensupport
8 weeks ago

Given Patch - https://core.trac.wordpress.org/attachment/ticket/61846/61846.patch
I would also like to agree after applying this solution, it works smoothly.

Last edited 8 weeks ago by ugyensupport (previous) (diff)

@sabernhardt
8 weeks ago

sets Outline style text color to currentColor in theme's blocks.css stylesheet

#2 @sabernhardt
8 weeks ago

  • Focuses css added
  • Keywords has-patch needs-testing added
  • Summary changed from Twenty Twelve : Button block text color is different in both side to Twenty Twelve: Button block Outline style has the wrong text color on the front
  • Version set to 6.6

With the first patch, removing the theme's text color would change the Fill style's default text color (to white).

Before WordPress 6.6, block-library styles set the Outline style's text color to currentColor at a higher specificity (0-4-0 now reduced to 0-1-0). The theme could try reducing specificity too, but that would change several selectors. I just added the text color for the Outline style in blocks.css.

#3 @karmatosed
8 weeks ago

  • Milestone changed from Awaiting Review to 6.7
  • Owner set to karmatosed
  • Status changed from new to assigned

Thanks everyone, assigning to myself to test and see about progressing.

#4 @karmatosed
8 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58885:

Twenty Twelve: Fixes Button block outline style having wrong text color on front.

The Button block has a different text color on the front to the editor when you apply text color. This resolves it without changing other styles.

Props pitamdey, ugyensupport, sabernhardt.
Fixes #61846.

#5 @karmatosed
8 weeks ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.