Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #62008, comment 7


Ignore:
Timestamp:
09/09/2024 11:53:55 AM (10 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #62008, comment 7

    initial v1  
    11My comment about the floating was before applying a patch (which would remove the float).
    22
    3 I do not think it needs `flex`, but that would belong on `#nav-single` so it does not affect other `nav` elements. Then the patch would also need to remove `display: block` at the 650px breakpoint (in `style.css`) and `float: left` in `rtl.css`.
     3I do not think the navigation needs `flex`, but that would belong on `#nav-single` so it does not affect other `nav` elements. Then the patch would also need to remove `display: block` at the 650px breakpoint (in `style.css`) and `float: left` in `rtl.css`.
    44
    5 PR 7313 likewise would need to remove `float: left` in `rtl.css`. Note that deleting the rule in line 1798 changes the layout at any screen size.
     5PR 7313 likewise would need to remove `float: left` in `rtl.css`. Note that deleting the rule in line 1798 of `style.css` changes the layout at any screen size.
    66
    77If it is worth changing the way the navigation displays after 13 years, we could remove more style rules. Floating the navigation to the right is an accessibility bug similar to #60496, and absolute positioning for the `.entry-meta` also goes against the DOM order.