Remove obsolete conditional in wp-admin/user-new.php

[SergeyBiryukov]

As a result of ​mu:641, ​mu:1529, [12722], and [16294], there is a redundant condition in wp-admin/user-new.php:

$username = $user_details->user_login;
...
if ( null != $username && ... ) {

The null != $username part was initially added for $username = $wpdb->get_var() in ​mu:641, but now that $username is set to $user_details->user_login, it will never be null in this specific line, so this part of the conditional can be removed.

Trac ticket: https://core.trac.wordpress.org/ticket/62012

This PR removes Obsolete conditional in wp-admin/user-new.php

[mukesh27]

Thanks @akshat2802 for the PR.

PR ready for commit.

[SergeyBiryukov]

In 58999:

Users: Remove obsolete conditional in wp-admin/user-new.php.

Since $username is set to $user_details->user_login, it will never be null in this specific line.

Follow-up to ​mu:641, ​mu:1529, [12722], [16294].

Props akshat2802, mukesh27, aristath, SergeyBiryukov.
Fixes #62012.

Thanks for the PR! Merged in r58999.

[iflairwebtechnologies]

Removed obsolete conditional in wp-admin/user-new.php and added 62012.patch

@iflair this has already been merged in ​https://github.com/WordPress/wordpress-develop/commit/a30b9b444fbdd30d711f7e597794eb958764ea56.

You can close this issue.

Already merged.