Make WordPress Core

Opened 16 months ago

Last modified 6 months ago

#62064 new defect (bug)

Refresh Authorize Application page UI

Reported by: jeffpaul's profile JeffPaul Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Application Passwords Keywords: needs-design needs-copy-review good-first-bug needs-testing has-patch
Focuses: ui, ui-copy Cc:

Description

The Authorize Application screen that you get popped into when approving an Application Password via a logged in account has some UI deficiencies for particularly long links and primary and secondary buttons that are stacked with varying formatted text between them. This feels like a good opportunity for a UI improvement to make this experience a bit less visually complex and cognitively confusing for users.

Attachments (5)

Authorize-Application.png (473.0 KB) - added by JeffPaul 16 months ago.
screenshot of a sample screen with overflowing URL text and stacked action buttons
Screenshot 2024-10-01 223946.png (64.3 KB) - added by denstyll 15 months ago.
Authorize Application fixed
Screenshot 2024-10-02 at 9.01.24 AM.png (96.7 KB) - added by pratiklondhe 15 months ago.
UI still seems to be breaking for long strings, tested on the latest trunk branch pull
62064.diff (344 bytes) - added by pratiklondhe 15 months ago.
Small change to fix the long strings going out of the card div
Screenshot 2024-11-09 at 3.11.53 PM.png (422.7 KB) - added by gsalo 14 months ago.
evidence of word wrap working fine

Download all attachments as: .zip

Change History (15)

@JeffPaul
16 months ago

screenshot of a sample screen with overflowing URL text and stacked action buttons

#1 @JeffPaul
16 months ago

  • Keywords good-first-bug added

This ticket was mentioned in Slack in #design by jeffpaul. View the logs.


16 months ago

@denstyll
15 months ago

Authorize Application fixed

#3 @denstyll
15 months ago

Hey Jeff,

Looks like this has already been resolved. I've attached the image confirming.

@pratiklondhe
15 months ago

UI still seems to be breaking for long strings, tested on the latest trunk branch pull

#4 @pratiklondhe
15 months ago

A better user experience might be to display a popup showing the URL, informing the user that they will be redirected after approval/rejection, and asking for confirmation.

@pratiklondhe
15 months ago

Small change to fix the long strings going out of the card div

@gsalo
14 months ago

evidence of word wrap working fine

This ticket was mentioned in PR #7871 on WordPress/wordpress-develop by @tusharaddweb.


13 months ago
#7

  • Keywords has-patch added; needs-patch removed

Scenarios Observed:

Text Does Not Overflow:

When the application name (app_name parameter) contains paragraphs or spaces between words, the text is wrapped appropriately within the card area.
Example URL:

http://localhost:8889/wp-admin/authorize-application.php?app_name=Contrary+to+popular+belief%2C+Lorem+Ipsum+is+not+simply+random+text.+It+has+roots+in+a+piece+of+classical+Latin+literature+from+45+BC%2C+making+it+over+2000+years+old.+Richard+McClintock%2C+a+Latin+professor+at+Hampden-Sydney+College+in+Virginia%2C+looked+up+one+of+the+more+obscure+Latin+words%2C+consectetur%2C+from+a+Lorem+Ipsum+passage%2C+and+going+through+the+cites+of+the+word+in+classical+literature%2C+discovered+the+undoubtable+source.

Screenshot: [Attached above showing proper wrapping.]

Text Overflows:

When the application name (app_name parameter) contains continuous text without any spaces or breaks, the text exceeds the boundaries of the card area and breaks the layout.
Example URL:

http://localhost:8889/wp-admin/authorize-application.php?app_name=asdflaksdklfjakldjfklajdfklasdkfjaklsdjjajknmmakalsjdkfjklajsdklfjaksdjfkasdjfkjsdfkaskdlfjaklsjdfklasjdfklajsdfkljakljsdklfjkljklajsdklfjklajsdfkljaklsdjfakljdfklajdfklasjdfklajsdfkljasdklfjaskldfjaslkdfjaskldjflaksjdfklasdjflkasjdflkajsdfasdkljfaklsjdfasjdfkaljsdfkladsf

Screenshot: https://prnt.sc/VxFBi60ZcnxC

https://prnt.sc/sc3mGyEpd05U
https://prnt.sc/tc2Y1rLFsm6R

Trac ticket: https://core.trac.wordpress.org/ticket/62064

---
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
https://github.com/user-attachments/assets/7bef940c-0314-4089-8324-90831189222a
https://github.com/user-attachments/assets/eb476c66-71bf-4c48-ad2b-56fb80b74b4f
https://github.com/user-attachments/assets/94624806-1b93-47da-a0a8-3b25117ff872

@pratiklondhe commented on PR #7871:


11 months ago
#8

Hi @tushar-addweb,
Thank you for the PR!
It seems the files might have been auto-formatted by your editor during saving. Could you please double-check this?

rogerkinsta commented on PR #7871:


6 months ago
#9

Trying to test the patch via the Playground link but playground errors out with this:

[09-Jul-2025 21:38:37 UTC] JavaScript Error: PHP.run() failed with exit code 255 and the following output: PHP Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23
PHP Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}

thrown in /internal/eval.php on line 23

<br />
<b>Warning</b>: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in <b>/internal/eval.php</b> on line <b>23</b><br />
<br />
<b>Fatal error</b>: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}

thrown in <b>/internal/eval.php</b> on line <b>23</b><br />

Error: PHP.run() failed with exit code 255 and the following output: PHP Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23
PHP Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}

thrown in /internal/eval.php on line 23

<br />
<b>Warning</b>: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in <b>/internal/eval.php</b> on line <b>23</b><br />
<br />
<b>Fatal error</b>: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}

thrown in <b>/internal/eval.php</b> on line <b>23</b><br />

at PHP.run (https://playground.wordpress.net/worker-thread-DAGie4cn.js:53:904)
at async unzipFile (https://playground.wordpress.net/worker-thread-DAGie4cn.js:96:1245)
at async unzipWordPress (https://playground.wordpress.net/worker-thread-DAGie4cn.js:816:76)
at async bootWordPress (https://playground.wordpress.net/worker-thread-DAGie4cn.js:476:558)
at async PlaygroundWorkerEndpoint.boot (https://playground.wordpress.net/worker-thread-DAGie4cn.js:1699:3322)

#10 @rogermedia
6 months ago

  • Keywords needs-testing added

@tushar-addweb The patch seems to be causing an error in Playground when trying to test. Can you please have a look?

Note: See TracTickets for help on using tickets.