Context Navigation

← Previous Ticket
Next Ticket →

#62231 closed defect (bug) (fixed)

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

Reported by:	mmaattiiaass	Owned by:	peterwilsoncc
Milestone:	6.7	Priority:	normal
Severity:	normal	Version:	6.7
Component:	Editor	Keywords:	has-patch has-unit-tests needs-testing has-testing-info
Focuses:		Cc:

Description

Description
When switching style variations, the font faces defined in those variations are not loaded in the editor but after the page is reloaded.

Step-by-step reproduction instructions
Switch to a theme style variation with custom font faces defined.
Check that the fonts are not loaded in the editor until the page is refreshed (browser reload).

Originally reported in GitHub repo: https://github.com/WordPress/gutenberg/issues/59965

Change History (10)

This ticket was mentioned in PR #7570 on WordPress/wordpress-develop by @mmaattiiaass.

4 months ago #1

Keywords has-patch has-unit-tests added

Resolve theme relative font faces URIs in theme.json and style variations.
Porting this change from Gutenberg repo: https://github.com/WordPress/gutenberg/pull/65019

Trac ticket: [](https://core.trac.wordpress.org/ticket/62231)

This ticket was mentioned in PR #7581 on WordPress/wordpress-develop by @mmaattiiaass.

3 months ago #2

Load fonts from style variations only in the editor and admin, not in the public frontend.

This is an alternative and probably simpler alternative to the Gutenberg PR: https://github.com/WordPress/gutenberg/pull/65019 and it core port PR: https://github.com/WordPress/wordpress-develop/pull/7570

Trac ticket: https://core.trac.wordpress.org/ticket/62231

#3 @ironprogrammer
3 months ago

Keywords needs-testing has-testing-info added

This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.

3 months ago

#5 @ironprogrammer
3 months ago

Component changed from General to Editor
Milestone changed from Awaiting Review to 6.7

Thanks for the patch and convenient test theme, @mmaattiiaass! This PR works as advertised in my testing, and I've moved this ticket to the 6.7 milestone for visibility (it's already on the 6.7 editor board). (Note that the first PR did not work for me.)

Test Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7581 (second, "simpler alternative" PR)

Environment

Hardware: MacBook Pro Apple M1 Pro
OS: macOS 14.6.1
Browser: Safari 17.6
Server: nginx/1.27.1
PHP: 8.3.12
MySQL: 8.0.27
WordPress: 6.7-beta3-59237-src
Theme: font-variants (zip from PR description)

Actual Results

✅ Custom fonts in style variations are immediately and accurately reflected in the style thumbnails and editor preview. No page refresh is needed to show the custom fonts.

Supplemental Artifacts

Click an image for a large version.

Left Styles browser	Right Styles browser

Prefer videos? See these before patch and after patch recordings.

#6 @peterwilsoncc
3 months ago

Owner set to peterwilsoncc
Resolution set to fixed
Status changed from new to closed

In 59260:

Editor: Load all style variation fonts within the editors.

Loads the font family files from style variations defined within a theme for user in the site and post editors. This is to ensure the fonts are shown while editing without the need for a reload after switching styles.

Props ironprogrammer, mmaattiiaass.
Fixes #62231.

@peterwilsoncc commented on PR #7581:

3 months ago #7

Merged r59260 / https://github.com/WordPress/wordpress-develop/commit/ba472085a05c837e42ab38f16aa06d90c3759994

Thanks Matias.

#8 @ugyensupport
3 months ago