wp_is_https_supported uses deprecated function

[peter8nss]

Function wp_update_https_detection_errors is marked as deprecated but is still used by function wp_is_https_supported.

Think this is triggered from cron job wp_site_health_scheduled_check. I think it will only occur on the first run of this after a new installation if option https_detection_errors is not already set. After that, option https_detection_errors will be set, and the call to wp_update_https_detection_errors will be bypassed.

[swissspidy]

cc @flixos90

Trac Ticket: Core-62252

## Summary

• This pull request updates the wp_is_https_supported function to remove the use of the deprecated HTTPS detection mechanism. Instead, it now utilizes the wp_get_https_detection_errors function, which is the recommended approach for determining HTTPS support on the server and domain.

## Changes Made

• Replaced the deprecated logic for checking HTTPS support with a call to wp_get_https_detection_errors().

• Updated the return statement to check for errors returned by the new method. If there are any errors, the function will return false, indicating that HTTPS is not supported.

## Detailed Explanation

• Reason for Change: The previous implementation of wp_is_https_supported relied on a deprecated method that may no longer function as expected in future releases. Using wp_get_https_detection_errors aligns with the current best practices for handling HTTPS detection in WordPress.

Functionality:

• The updated wp_is_https_supported function checks for any HTTPS detection errors by calling wp_get_https_detection_errors().

• It returns true if no errors are found, indicating that HTTPS is supported, and false if there are errors.

Hi @peterwilsoncc , can you please take a look into this PR. Thanks.

[flixos90]

See #58494 for the original ticket that made the change.

The PR looks technically good to me, but we should address a few things in the documentation per ​https://github.com/WordPress/wordpress-develop/pull/7598/files#r1809152986.

Hi @felixarntz , I have updated the Doc block comments, can you please take a look into it. Thanks.

[debarghyabanerjee]

#62364 was marked as a duplicate.

Replaced the deprecated wp_update_https_detection_errors() function with wp_get_https_detection_errors() to align with the latest WordPress standards and avoid deprecation warnings.

Trac ticket: https://core.trac.wordpress.org/ticket/62252

[desrosj]

I've gone and pointed the PR associated with #62364 to this ticket so it also can be considered. Props to @sebastienserre for that one.

@geekofshire Thank you for the pull request! It looks like this is a duplicate of #7598, which already implemented this change correctly, so I'm going to close this in favor of the other PR. I'll make sure to give you props on the WordPress Core commit though, thanks again!

[flixos90]

In 59517:

Site Health: Remove use of deprecated function from wp_is_https_supported().

Follow up to [56664].

Props peter8nss, debarghyabanerjee, sebastienserre, geekofshire, swissspidy, desrosj.
Fixes #62252.
See #58494.

Committed in https://core.trac.wordpress.org/changeset/59517