class-wp-user.php can throw a warning for trim() when $value is null

[heuptasje]

It seems like the class-wp-user.php class can throw a deprecated warning on the trim() function when $value is null.

Moved the null check above the usage of $value, as this could be null. If the $value is null, a deprecation warning will be thrown for the trim() function.

Trac ticket: https://core.trac.wordpress.org/ticket/62276

[knutsp]

If $value is null when docs day @param string|int then the error is correct. Why silence it?

[heuptasje]

Replying to knutsp:

If $value is null when docs day @param string|int then the error is correct. Why silence it?

I don't think we should allow it to go through to a function that will throw a deprecation error either. I'd say we'd rather have it return false then.