Make WordPress Core

#62373 closed defect (bug) (fixed)

Coding Standards: esc_attr to esc_url

Reported by: hiteshhuptechweb Owned by: SergeyBiryukov
Priority: normal Milestone: 6.8
Component: Comments Version:
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

I reviewed files and then i found one of change escape function esc_attr to esc_url src\wp-admin\edit-form-comment.php

Attachments (1)

62373.patch (765 bytes ) - added by hiteshhuptechweb 22 months ago.

Download all attachments as: .zip

Change History (3)

#1 @sabernhardt
22 months ago

  • Milestone Awaiting Review6.8

#56140 did not replace the function in user-new.php, but esc_url() seems more appropriate for comment authors. The comment author URL requires a valid URL (it adds http:// to something like 'none').

Changesets related to escaping newcomment_author_url include [5543], [9436], [11104], [11204] and [11739].

#2 @SergeyBiryukov
22 months ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 59388:

Coding Standards: Use esc_url() for comment author URL in Edit Comment form.

Follow-up to [5543], [9436], [11104], [11204], [11739].

Props hiteshhuptechweb, sabernhardt.
Fixes #62373.

Note: See TracTickets for help on using tickets.