Make WordPress Core

Opened 5 months ago

Closed 5 weeks ago

Last modified 4 weeks ago

#62637 closed defect (bug) (fixed)

Misplaced filter themes wrapper (under Customize > Change Theme > .org themes browser)

Reported by: kharisblank's profile kharisblank Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-screenshots has-patch has-testing-info commit
Focuses: ui, css, administration Cc:

Description

Steps to reproduce the issue:

  1. Go to Customize
  2. Click on Change theme button
  3. Switch to WordPress.org themes

https://cldup.com/SKm44fh4kJ.png

Screen recording: https://cldup.com/tiBD_mLB5Q.mov

Attachments (5)

after-7942.png (798.2 KB) - added by parthvataliya 5 months ago.
after-patch.png (917.5 KB) - added by praful2111 4 months ago.
Customize_ WordPress Develop.webm (2.3 MB) - added by ruchirj 4 months ago.
before-patch.png (1.0 MB) - added by shailu25 6 weeks ago.
Before Patch.
after-patch.2.png (1.1 MB) - added by shailu25 6 weeks ago.
After Patch.

Change History (28)

#1 @ankitkumarshah
5 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.7.1
  • PHP: 8.1.29
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.8
  • MU Plugins: None activated

Actual Results

  1. ✅ Error condition occurs (reproduced).

Supplemental Artifacts

https://i.postimg.cc/kGpJdPTJ/Screenshot-2024-12-03-at-6-28-05-PM.png

#2 @benazeer
5 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.7.1
  • PHP: 8.1.22
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.22)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.8
  • MU Plugins: None activated
  • Plugins:
    • Gutenberg 19.7.0-rc.1
    • Test Reports 1.2.0

Actual Results

  1. ✅ Error condition occurs (reproduced).

Screenshot:
https://postimg.cc/Y4yM7TCz
https://postimg.cc/Y4yM7TCz

Last edited 5 months ago by benazeer (previous) (diff)

This ticket was mentioned in PR #7939 on WordPress/wordpress-develop by @ankitkumarshah.


5 months ago
#3

  • Keywords has-patch added

Trac ticket: #62637

## Description
This PR addresses an issue where the "Filter themes" wrapper element was misplaced within the "Customize > Change Theme > .org themes browser" section of the application.

#4 @sainathpoojary
5 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7939

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.4
  • MU Plugins: None activated
  • Plugins: Test Reports 1.2.0

Actual Results

✅ Issue resolved with patch.

Supplemental Artifacts

Before:

https://utfs.io/f/PL8E4NiPUWyOSF6nzNLiQ4fwdzrJyI7ZFLWB3XOnMKUARmPD

After:

https://utfs.io/f/PL8E4NiPUWyO21fkheMrbSwhDZXGLqs4KMo8zvf5xlc7yBV1

#7 @mukesh27
5 months ago

  • Keywords has-testing-info added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 6.8
  • Version 6.7.1 deleted

Thanks for ticket.

I also reproduce the issue and open PR https://github.com/WordPress/wordpress-develop/pull/7942 that update the class for wrapper DIV.

Take a look and share your feedback.

Moving to 6.8 for visibility.

@ankitkumarshah commented on PR #7942:


5 months ago
#8

Hi @mukeshpanchal27,
I tested the changes and really like the alignment of the search bar and filter button. According to my understanding, I believe that if we remove the search-form class, it would be beneficial to also eliminate the corresponding class names from the CSS to maintain cleanliness and avoid redundancy. For example:

.customize-preview-header.themes-filter-bar .search-form{}

.customize-preview-header.themes-filter-bar .search-form
	.themes-filter-bar .themes-filter-container{}

Removing these class names from the CSS would help streamline the code since they are no longer needed. Please let me know if my understanding is correct.

@kharisblank commented on PR #7942:


5 months ago
#9

Hi @mukeshpanchal27,

I tested out the patch, and it looks really great.

https://github.com/user-attachments/assets/be2a2bc5-9219-430e-bc73-81ef6de08bbe

#10 @parthvataliya
5 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: Linux
  • Theme: Twenty Eleven 4.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • I tested the PR opened by @mukesh27 , and it works fine with all the functionality. Adding the filter option in this place is ideal.
Last edited 5 months ago by parthvataliya (previous) (diff)

#11 @im3dabasia1
5 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 129.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Error condition occurs (reproduced).

Supplemental Artifacts

https://i.postimg.cc/QN0gGVQc/Screenshot-2024-12-04-at-7-06-04-PM.png

Last edited 5 months ago by im3dabasia1 (previous) (diff)

#12 @im3dabasia1
5 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 129.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

https://i.postimg.cc/cH6xvDzx/Screenshot-2024-12-04-at-7-10-59-PM.png

#13 @sukhendu2002
5 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#14 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#15 @praful2111
4 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#16 @ruchirj
4 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.4.2 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: Linux
  • Theme: Twenty Thirteen 4.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#17 @imranhasanraaz
6 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/7942.diff

Environment

  • WordPress: 6.8-beta1-59933-src
  • PHP: 7.4.33
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 133.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

✅ Issue resolved with patch.

Before : https://prnt.sc/Mo6wj38qv8UL
After : https://prnt.sc/03mL3w9apu00

#18 @shailu25
6 weeks ago

Test Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/7942

Environment:
WordPress - 6.8-beta1
OS - Windows
Browser - Firefox
Theme: Twenty Twenty
PHP - 8.2.12
Active Plugin: None

Actual Results:

  • Issue Resolved With Patch.✅

Screenshots:

  • Added Attachment
Last edited 6 weeks ago by shailu25 (previous) (diff)

@shailu25
6 weeks ago

Before Patch.

@shailu25
6 weeks ago

After Patch.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 weeks ago

#20 @audrasjb
5 weeks ago

  • Keywords commit added

Self assigning for commit.

#21 @audrasjb
5 weeks ago

  • Owner changed from SergeyBiryukov to audrasjb
  • Status changed from reviewing to accepted

#22 @audrasjb
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 60039:

Customize: Improve alignment of theme wrapper.

This changeset updates the class used for the theme wrapper in the customizer, which fixes an alignment issue occuring when searching a theme on WordPress.org from the customizer interface.

Props kharisblank, ankitkumarshah, benazeer, sainathpoojary, mukesh27, kharisblank, parthvataliya, im3dabasia1, sukhendu2002, praful2111, ruchirj, imranhasanraaz, shailu25.
Fixes #62637.

Note: See TracTickets for help on using tickets.