WordPress.org
Get WordPress

Make WordPress Core

Opened 32 hours ago

Closed 18 hours ago

Last modified 18 hours ago

#62746 closed defect (bug) (fixed)

after_section not printed if $wp_settings_section doesn't have fields attached

Reported by: alpipego's profile alpipego Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch
Focuses: Cc:

Description

If a settings section doesn't have any fields attached via $wp_settings_fields the additional after_section argument doesn't get printed. before_section does, however.

Change History (8)

#1 @alpipego
32 hours ago

  • Resolution set to invalid
  • Status changed from new to closed

#2 @alpipego
32 hours ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

The $args

Version 0, edited 32 hours ago by alpipego (next)

This ticket was mentioned in ​PR #8055 on ​WordPress/wordpress-develop by ​@alpipego.
32 hours ago #3

  • Keywords has-patch added

When a section did not have fields attached, the loop moved to the next item. By inverting the logic check for fields, this change makes sure the after_section argument gets printed.

Trac ticket: https://core.trac.wordpress.org/ticket/62746

#5 @alpipego
32 hours ago

  • Keywords has-patch added

#6 @SergeyBiryukov
18 hours ago

  • Milestone changed from Awaiting Review to 6.8

#7 @SergeyBiryukov
18 hours ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 59564:

Options, Meta APIs: Ensure after_section is printed for sections without any fields.

This brings consistency with the before_section HTML content, which did get printed in do_settings_sections() regardless of whether the settings section has any fields attached.

Follow-up to [8855], [21742], [54247].

Props alpipego, SergeyBiryukov.
Fixes #62746.

​@SergeyBiryukov commented on ​PR #8055:
18 hours ago #8

Thanks for the PR! Merged in r59564.

Note: See TracTickets for help on using tickets.