Make WordPress Core

Opened 2 weeks ago

Last modified 2 weeks ago

#62844 new defect (bug)

Fix performance monitoring workflow to not send duplicate results for a single commit

Reported by: flixos90's profile flixos90 Owned by:
Milestone: Future Release Priority: low
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: performance Cc:

Description

See https://core.trac.wordpress.org/ticket/62221#comment:75: When the main portion of the performance monitoring workflow is successful, but the workflow is still rerun (e.g. because a subsequent portion of it failed), it will currently send the data for the same commit again (as it happened for [59679] / Git hash 8209135dfc327dc24a274efb0d3f01381e48c739).

This is not ideal, so it would be better to either not send the commit data if there is already a record for it in the metric, or alternatively, send the commit data in a way that it overrides the previous data for the commit.

In practice, this scenario of rerunning the partially successful workflow should be an edge-case, hence I'm marking this as low priority.

Change History (1)

#1 @swissspidy
2 weeks ago

or alternatively, send the commit data in a way that it overrides the previous data for the commit.

That makes most sense to me. But this should be done on the codevitals side.

Note: See TracTickets for help on using tickets.