WordPress.org
Get WordPress

Make WordPress Core

Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#62906 closed enhancement (fixed)

Allow :focus-visible pseudo-selector to be set in theme.json

Reported by: huubl Owned by: joedolson
Priority: normal Milestone: 6.8
Component: Themes Version:
Severity: normal Keywords: has-patch commit gutenberg-merge
Cc: Focuses: accessibility, css

Description (last modified by joedolson)

See also the paired Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/68521

These should be handled together.

Change History (19)

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
20 months ago

#4 @joedolson
20 months ago

  • Description modified (diff)

\

#5 @joedolson
20 months ago

  • Milestone Awaiting Review → 6.8
  • Owner set to joedolson
  • Status new → accepted

#6 @audrasjb
20 months ago

  • Component General → Themes
  • Focuses css added
  • Keywords commit added

As per today's accessibility bug scrub, ​I added the related Gutenberg PR to milestone 6.8. We can commit this ticket and merge the related Gutenberg changeset in whatever order we prefer.

Last edited 20 months ago by audrasjb (previous) (diff)

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
20 months ago

#8 @joedolson
20 months ago

  • Resolution → fixed
  • Status accepted → closed

In 59854:

Themes: Support :focus-visible in theme.json.

Add the :focus-visible pseudo selector as a valid element in the theme.json schema. See also ​https://github.com/WordPress/gutenberg/pull/68521.

Props huubl, audrasjb, poena, sabernhardt, afercia, annebovelett.
Fixes #62906.

#10 @joemcgill
20 months ago

  • Keywords gutenberg-merge added

​@huubl commented on ​PR #8261:
20 months ago #11

@joedolson I think my ​last commit is missing here.

#12 @huubl
19 months ago

  • Keywords has-patch, commit, gutenberg-merge → has-patch commit gutenberg-merge
  • Resolution fixed
  • Status closed → reopened

@joedolson @joemcgill @audrasjb the changes r59854 are incomplete / not including the changes as merged in ​https://github.com/WordPress/gutenberg/pull/68521. The ​last commit is missing here. Can you please take a look?

#13 @joemcgill
19 months ago

Thanks for the heads up, @huubl. @joedolson do you have time to take another look? If not, feel free to reassign to me.

#14 @joedolson
19 months ago

@joemcgill Yeah, I can take care of that. That's a weird thing to have omitted, but I don't recall having seen that change at all...

#15 @joedolson
19 months ago

Oh, I see - that's the Gutenberg merge PR, not the one I merged. Checking on it.

#16 @joedolson
19 months ago

OK; I see that PR 8261 never got updated with later changes from the upstream PR, and I overlooked that. Straightforward; just needs to be checked and committed.

#18 @joedolson
19 months ago

  • Resolution → fixed
  • Status reopened → closed

In 60055:

Themes: A11y: Merge omitted changes to support focus-visible.

Merge PHP changes to ensure that focus doesn't match focus-visible in WP_Theme_JSON, overlooked in previous merge. Follow up to [59854].

Props huubl, joemcgill, joedolson.
Fixes #62906.

#19 @huubl
19 months ago

Thanks @joedolson @joemcgill!

Note: See TracTickets for help on using tickets.