WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#62906 closed enhancement (fixed)

Allow :focus-visible pseudo-selector to be set in theme.json

Reported by: huubl's profile huubl Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit gutenberg-merge
Focuses: accessibility, css Cc:

Description (last modified by joedolson)

See also the paired Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/68521

These should be handled together.

Change History (19)

This ticket was mentioned in ​PR #8261 on ​WordPress/wordpress-develop by ​@huubl.
5 months ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/62906
Gutenberg ticket: ​https://github.com/WordPress/gutenberg/pull/68521

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
5 months ago

#4 @joedolson
5 months ago

  • Description modified (diff)

\

#5 @joedolson
5 months ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to joedolson
  • Status changed from new to accepted

#6 @audrasjb
5 months ago

  • Component changed from General to Themes
  • Focuses css added
  • Keywords commit added

As per today's accessibility bug scrub, ​I added the related Gutenberg PR to milestone 6.8. We can commit this ticket and merge the related Gutenberg changeset in whatever order we prefer.

Last edited 5 months ago by audrasjb (previous) (diff)

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
5 months ago

#8 @joedolson
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59854:

Themes: Support :focus-visible in theme.json.

Add the :focus-visible pseudo selector as a valid element in the theme.json schema. See also ​https://github.com/WordPress/gutenberg/pull/68521.

Props huubl, audrasjb, poena, sabernhardt, afercia, annebovelett.
Fixes #62906.

​@joedolson commented on ​PR #8261:
5 months ago #9

in r59854

#10 @joemcgill
5 months ago

  • Keywords gutenberg-merge added

​@huubl commented on ​PR #8261:
5 months ago #11

@joedolson I think my ​last commit is missing here.

#12 @huubl
4 months ago

  • Keywords changed from has-patch, commit, gutenberg-merge to has-patch commit gutenberg-merge
  • Resolution fixed deleted
  • Status changed from closed to reopened

@joedolson @joemcgill @audrasjb the changes r59854 are incomplete / not including the changes as merged in ​https://github.com/WordPress/gutenberg/pull/68521. The ​last commit is missing here. Can you please take a look?

#13 @joemcgill
4 months ago

Thanks for the heads up, @huubl. @joedolson do you have time to take another look? If not, feel free to reassign to me.

#14 @joedolson
4 months ago

@joemcgill Yeah, I can take care of that. That's a weird thing to have omitted, but I don't recall having seen that change at all...

#15 @joedolson
4 months ago

Oh, I see - that's the Gutenberg merge PR, not the one I merged. Checking on it.

#16 @joedolson
4 months ago

OK; I see that PR 8261 never got updated with later changes from the upstream PR, and I overlooked that. Straightforward; just needs to be checked and committed.

#18 @joedolson
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 60055:

Themes: A11y: Merge omitted changes to support focus-visible.

Merge PHP changes to ensure that focus doesn't match focus-visible in WP_Theme_JSON, overlooked in previous merge. Follow up to [59854].

Props huubl, joemcgill, joedolson.
Fixes #62906.

#19 @huubl
4 months ago

Thanks @joedolson @joemcgill!

Note: See TracTickets for help on using tickets.